2021-05-26 03:09:44

by Yang Li

Subject: [PATCH] pinctrl: Fix kernel-doc

Fix function name in pinctrl-single.c kernel-doc comment
to remove a warning found by clang_w1.

drivers/pinctrl/pinctrl-single.c:1523: warning: expecting prototype for
pcs_irq_handle(). Prototype was for pcs_irq_chain_handler() instead.

Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Yang Li <[email protected]>
---
drivers/pinctrl/pinctrl-single.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pinctrl/pinctrl-single.c b/drivers/pinctrl/pinctrl-single.c
index 2c9c983..7834d5d 100644
--- a/drivers/pinctrl/pinctrl-single.c
+++ b/drivers/pinctrl/pinctrl-single.c
@@ -1513,7 +1513,7 @@ static irqreturn_t pcs_irq_handler(int irq, void *d)
}

/**
- * pcs_irq_handle() - handler for the dedicated chained interrupt case
+ * pcs_irq_chain_handler() - handler for the dedicated chained interrupt case
* @desc: interrupt descriptor
*
* Use this if you have a separate interrupt for each
--
1.8.3.1

2021-05-28 00:52:11

by Linus Walleij

Subject: Re: [PATCH] pinctrl: Fix kernel-doc

On Wed, May 26, 2021 at 5:07 AM Yang Li <[email protected]> wrote:

> Fix function name in pinctrl-single.c kernel-doc comment
> to remove a warning found by clang_w1.
>
> drivers/pinctrl/pinctrl-single.c:1523: warning: expecting prototype for
> pcs_irq_handle(). Prototype was for pcs_irq_chain_handler() instead.
>
> Reported-by: Abaci Robot <[email protected]>
> Signed-off-by: Yang Li <[email protected]>

Patch applied.

Yours,
Linus Walleij