2021-05-26 04:11:14

by Yang Li

Subject: [PATCH] i2c: designware: Fix kernel-doc

Fix function name in i2c-designware-master.c kernel-doc comment
to remove a warning found by clang_w1.

drivers/i2c/busses/i2c-designware-master.c:176: warning: expecting
prototype for i2c_dw_init(). Prototype was for i2c_dw_init_master()
instead.

Reported-by: Abaci Robot <[email protected]>
Fixes: 'commit 21bf440ce18e ("i2c: designware: Make HW init functions
static")'
Signed-off-by: Yang Li <[email protected]>
---
drivers/i2c/busses/i2c-designware-master.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/i2c/busses/i2c-designware-master.c b/drivers/i2c/busses/i2c-designware-master.c
index 13be1d6..9b08bb5 100644
--- a/drivers/i2c/busses/i2c-designware-master.c
+++ b/drivers/i2c/busses/i2c-designware-master.c
@@ -165,7 +165,7 @@ static int i2c_dw_set_timings_master(struct dw_i2c_dev *dev)
}

/**
- * i2c_dw_init() - Initialize the designware I2C master hardware
+ * i2c_dw_init_master() - Initialize the designware I2C master hardware
* @dev: device private data
*
* This functions configures and enables the I2C master.
--
1.8.3.1

2021-05-26 06:12:51

by Jarkko Nikula

Subject: Re: [PATCH] i2c: designware: Fix kernel-doc

Hi

On 5/26/21 6:10 AM, Yang Li wrote:
> Fix function name in i2c-designware-master.c kernel-doc comment
> to remove a warning found by clang_w1.
>
> drivers/i2c/busses/i2c-designware-master.c:176: warning: expecting
> prototype for i2c_dw_init(). Prototype was for i2c_dw_init_master()
> instead.
>
> Reported-by: Abaci Robot <[email protected]>
> Fixes: 'commit 21bf440ce18e ("i2c: designware: Make HW init functions
> static")'
> Signed-off-by: Yang Li <[email protected]>
> ---
> drivers/i2c/busses/i2c-designware-master.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Lee Jones sent a fix for this last week:

https://www.spinics.net/lists/linux-i2c/msg51612.html

Jarkko