From: Peng Li <[email protected]>
This patchset clean up some code style issues.
---
Change log:
V1 -> V2:
1, Use appropriate commit prefix suggested by Jakub Kicinski,
replace commit prefix "net: wan" by "net: hdlc_fr".
---
Peng Li (10):
net: hdlc_fr: remove redundant blank lines
net: hdlc_fr: add blank line after declarations
net: hdlc_fr: fix an code style issue about "foo* bar"
net: hdlc_fr: add some required spaces
net: hdlc_fr: move out assignment in if condition
net: hdlc_fr: code indent use tabs where possible
net: hdlc_fr: remove space after '!'
net: hdlc_fr: add braces {} to all arms of the statement
net: hdlc_fr: remove redundant braces {}
net: hdlc_fr: remove unnecessary out of memory message
drivers/net/wan/hdlc_fr.c | 101 ++++++++++++++++------------------------------
1 file changed, 34 insertions(+), 67 deletions(-)
--
2.8.1
From: Peng Li <[email protected]>
Code indent should use tabs where possible.
Signed-off-by: Peng Li <[email protected]>
Signed-off-by: Guangbin Huang <[email protected]>
---
drivers/net/wan/hdlc_fr.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/net/wan/hdlc_fr.c b/drivers/net/wan/hdlc_fr.c
index a39e508..fa10eea 100644
--- a/drivers/net/wan/hdlc_fr.c
+++ b/drivers/net/wan/hdlc_fr.c
@@ -6,16 +6,16 @@
* Copyright (C) 1999 - 2006 Krzysztof Halasa <[email protected]>
*
- Theory of PVC state
+ Theory of PVC state
DCE mode:
(exist,new) -> 0,0 when "PVC create" or if "link unreliable"
- 0,x -> 1,1 if "link reliable" when sending FULL STATUS
- 1,1 -> 1,0 if received FULL STATUS ACK
+ 0,x -> 1,1 if "link reliable" when sending FULL STATUS
+ 1,1 -> 1,0 if received FULL STATUS ACK
(active) -> 0 when "ifconfig PVC down" or "link unreliable" or "PVC create"
- -> 1 when "PVC up" and (exist,new) = 1,0
+ -> 1 when "PVC up" and (exist,new) = 1,0
DTE mode:
(exist,new,active) = FULL STATUS if "link reliable"
--
2.8.1
From: Peng Li <[email protected]>
Fix the checkpatch error as "foo* bar" and should be "foo *bar",
and "(foo*)" should be "(foo *)".
Signed-off-by: Peng Li <[email protected]>
Signed-off-by: Guangbin Huang <[email protected]>
---
drivers/net/wan/hdlc_fr.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wan/hdlc_fr.c b/drivers/net/wan/hdlc_fr.c
index 96e4a89..4a6172c 100644
--- a/drivers/net/wan/hdlc_fr.c
+++ b/drivers/net/wan/hdlc_fr.c
@@ -159,7 +159,7 @@ static inline void dlci_to_q922(u8 *hdr, u16 dlci)
hdr[1] = ((dlci << 4) & 0xF0) | 0x01;
}
-static inline struct frad_state* state(hdlc_device *hdlc)
+static inline struct frad_state *state(hdlc_device *hdlc)
{
return(struct frad_state *)(hdlc->state);
}
@@ -1090,7 +1090,7 @@ static int fr_add_pvc(struct net_device *frad, unsigned int dlci, int type)
dev->priv_flags &= ~IFF_TX_SKB_SHARING;
eth_hw_addr_random(dev);
} else {
- *(__be16*)dev->dev_addr = htons(dlci);
+ *(__be16 *)dev->dev_addr = htons(dlci);
dlci_to_q922(dev->broadcast, dlci);
}
dev->netdev_ops = &pvc_ops;
--
2.8.1
Hello:
This series was applied to netdev/net-next.git (refs/heads/master):
On Fri, 28 May 2021 08:12:39 +0800 you wrote:
> From: Peng Li <[email protected]>
>
> This patchset clean up some code style issues.
>
> ---
> Change log:
> V1 -> V2:
> 1, Use appropriate commit prefix suggested by Jakub Kicinski,
> replace commit prefix "net: wan" by "net: hdlc_fr".
>
> [...]
Here is the summary with links:
- [V2,net-next,01/10] net: hdlc_fr: remove redundant blank lines
https://git.kernel.org/netdev/net-next/c/b11faec36870
- [V2,net-next,02/10] net: hdlc_fr: add blank line after declarations
https://git.kernel.org/netdev/net-next/c/4a9ab454ae9b
- [V2,net-next,03/10] net: hdlc_fr: fix an code style issue about "foo* bar"
https://git.kernel.org/netdev/net-next/c/7aad06425991
- [V2,net-next,04/10] net: hdlc_fr: add some required spaces
https://git.kernel.org/netdev/net-next/c/30e7720d379a
- [V2,net-next,05/10] net: hdlc_fr: move out assignment in if condition
https://git.kernel.org/netdev/net-next/c/168a196ffcff
- [V2,net-next,06/10] net: hdlc_fr: code indent use tabs where possible
https://git.kernel.org/netdev/net-next/c/683b54bb468f
- [V2,net-next,07/10] net: hdlc_fr: remove space after '!'
https://git.kernel.org/netdev/net-next/c/8f032c6535fe
- [V2,net-next,08/10] net: hdlc_fr: add braces {} to all arms of the statement
https://git.kernel.org/netdev/net-next/c/5d650a6c7b9c
- [V2,net-next,09/10] net: hdlc_fr: remove redundant braces {}
https://git.kernel.org/netdev/net-next/c/c9a2ca5d7e58
- [V2,net-next,10/10] net: hdlc_fr: remove unnecessary out of memory message
https://git.kernel.org/netdev/net-next/c/2744fa2dfdcd
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html