2021-05-27 09:38:12

by Zou Wei

Subject: [PATCH -next] regulator: bd71815: fix platform_no_drv_owner.cocci warnings

./drivers/regulator/bd71815-regulator.c:644:3-8: No need to set .owner here. The core will do it.

Remove .owner field if calls are used which set it automatically

Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci

Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Zou Wei <[email protected]>
---
drivers/regulator/bd71815-regulator.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/regulator/bd71815-regulator.c b/drivers/regulator/bd71815-regulator.c
index a079efa..4dd21ac 100644
--- a/drivers/regulator/bd71815-regulator.c
+++ b/drivers/regulator/bd71815-regulator.c
@@ -641,7 +641,6 @@ MODULE_DEVICE_TABLE(platform, bd7181x_pmic_id);
static struct platform_driver bd7181x_regulator = {
.driver = {
.name = "bd7181x-pmic",
- .owner = THIS_MODULE,
},
.probe = bd7181x_probe,
.id_table = bd7181x_pmic_id,
--
2.6.2

2021-05-27 10:12:39

by Matti Vaittinen

Subject: Re: [PATCH -next] regulator: bd71815: fix platform_no_drv_owner.cocci warnings

On Thu, 2021-05-27 at 17:54 +0800, Zou Wei wrote:
> ./drivers/regulator/bd71815-regulator.c:644:3-8: No need to set
> .owner here. The core will do it.
>
> Remove .owner field if calls are used which set it automatically
>
> Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci
>
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: Zou Wei <[email protected]>

Thanks!
Acked-by: Matti Vaittinen <[email protected]>

> ---
> drivers/regulator/bd71815-regulator.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/regulator/bd71815-regulator.c
> b/drivers/regulator/bd71815-regulator.c
> index a079efa..4dd21ac 100644
> --- a/drivers/regulator/bd71815-regulator.c
> +++ b/drivers/regulator/bd71815-regulator.c
> @@ -641,7 +641,6 @@ MODULE_DEVICE_TABLE(platform, bd7181x_pmic_id);
> static struct platform_driver bd7181x_regulator = {
> .driver = {
> .name = "bd7181x-pmic",
> - .owner = THIS_MODULE,
> },
> .probe = bd7181x_probe,
> .id_table = bd7181x_pmic_id,

2021-05-28 17:31:19

by Mark Brown

Subject: Re: [PATCH -next] regulator: bd71815: fix platform_no_drv_owner.cocci warnings

From: Mark Brown,,, <[email protected]>

On Thu, 27 May 2021 17:54:04 +0800, Zou Wei wrote:
> ./drivers/regulator/bd71815-regulator.c:644:3-8: No need to set .owner here. The core will do it.
>
> Remove .owner field if calls are used which set it automatically
>
> Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci

Applied, thanks!

[1/1] regulator: bd71815: fix platform_no_drv_owner.cocci warnings
commit: d149b855b955fe92ab16ddd59c1d540f82e6a40f

Best regards,
--
Mark Brown,,, <[email protected]>