2021-05-24 10:24:04

by Yang Li

Subject: [PATCH] clk: sifive: Fix kernel-doc

Fix function name in sifive-prci.c kernel-doc comment
to remove a warning.

drivers/clk/sifive/sifive-prci.c:573: warning: expecting prototype for
sifive_prci_init(). Prototype was for sifive_prci_probe() instead

Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Yang Li <[email protected]>
---
drivers/clk/sifive/sifive-prci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/sifive/sifive-prci.c b/drivers/clk/sifive/sifive-prci.c
index 0d79ba3..80a288c 100644
--- a/drivers/clk/sifive/sifive-prci.c
+++ b/drivers/clk/sifive/sifive-prci.c
@@ -564,7 +564,7 @@ static int __prci_register_clocks(struct device *dev, struct __prci_data *pd,
}

/**
- * sifive_prci_init() - initialize prci data and check parent count
+ * sifive_prci_probe() - initialize prci data and check parent count
* @pdev: platform device pointer for the prci
*
* Return: 0 upon success or a negative error code upon failure.
--
1.8.3.1

2021-05-29 23:09:09

by Palmer Dabbelt

Subject: Re: [PATCH] clk: sifive: Fix kernel-doc

On Mon, 24 May 2021 03:22:10 PDT (-0700), [email protected] wrote:
> Fix function name in sifive-prci.c kernel-doc comment
> to remove a warning.
>
> drivers/clk/sifive/sifive-prci.c:573: warning: expecting prototype for
> sifive_prci_init(). Prototype was for sifive_prci_probe() instead
>
> Reported-by: Abaci Robot <[email protected]>
> Signed-off-by: Yang Li <[email protected]>
> ---
> drivers/clk/sifive/sifive-prci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/sifive/sifive-prci.c b/drivers/clk/sifive/sifive-prci.c
> index 0d79ba3..80a288c 100644
> --- a/drivers/clk/sifive/sifive-prci.c
> +++ b/drivers/clk/sifive/sifive-prci.c
> @@ -564,7 +564,7 @@ static int __prci_register_clocks(struct device *dev, struct __prci_data *pd,
> }
>
> /**
> - * sifive_prci_init() - initialize prci data and check parent count
> + * sifive_prci_probe() - initialize prci data and check parent count
> * @pdev: platform device pointer for the prci
> *
> * Return: 0 upon success or a negative error code upon failure.

Acked-by: Palmer Dabbelt <[email protected]>
Reviewed-by: Palmer Dabbelt <[email protected]>

I'm assuming this is targeted for the clock tree, but LMK if you want me
to take it.

Thanks!

2021-06-02 06:46:25

by Stephen Boyd

Subject: Re: [PATCH] clk: sifive: Fix kernel-doc

Quoting Yang Li (2021-05-24 03:22:10)
> Fix function name in sifive-prci.c kernel-doc comment
> to remove a warning.
>
> drivers/clk/sifive/sifive-prci.c:573: warning: expecting prototype for
> sifive_prci_init(). Prototype was for sifive_prci_probe() instead
>
> Reported-by: Abaci Robot <[email protected]>
> Signed-off-by: Yang Li <[email protected]>
> ---

Applied to clk-next