2021-06-07 13:42:56

by Yang Yingliang

Subject: [PATCH net-next] net: macb: Use devm_platform_get_and_ioremap_resource()

Use devm_platform_get_and_ioremap_resource() to simplify
code.

Signed-off-by: Yang Yingliang <[email protected]>
---
drivers/net/ethernet/cadence/macb_main.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c
index a0c7b1167dbb..7d2fe13a52f8 100644
--- a/drivers/net/ethernet/cadence/macb_main.c
+++ b/drivers/net/ethernet/cadence/macb_main.c
@@ -4655,8 +4655,7 @@ static int macb_probe(struct platform_device *pdev)
struct macb *bp;
int err, val;

- regs = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- mem = devm_ioremap_resource(&pdev->dev, regs);
+ mem = devm_platform_get_and_ioremap_resource(pdev, 0, &regs);
if (IS_ERR(mem))
return PTR_ERR(mem);

--
2.25.1

2021-06-07 14:06:52

by Nicolas Ferre

Subject: Re: [PATCH net-next] net: macb: Use devm_platform_get_and_ioremap_resource()

On 07/06/2021 at 15:43, Yang Yingliang wrote:
> Use devm_platform_get_and_ioremap_resource() to simplify
> code.
>
> Signed-off-by: Yang Yingliang <[email protected]>

Acked-by: Nicolas Ferre <[email protected]>

> ---
> drivers/net/ethernet/cadence/macb_main.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c
> index a0c7b1167dbb..7d2fe13a52f8 100644
> --- a/drivers/net/ethernet/cadence/macb_main.c
> +++ b/drivers/net/ethernet/cadence/macb_main.c
> @@ -4655,8 +4655,7 @@ static int macb_probe(struct platform_device *pdev)
> struct macb *bp;
> int err, val;
>
> - regs = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - mem = devm_ioremap_resource(&pdev->dev, regs);
> + mem = devm_platform_get_and_ioremap_resource(pdev, 0, &regs);
> if (IS_ERR(mem))
> return PTR_ERR(mem);
>
> --
> 2.25.1
>


--
Nicolas Ferre

2021-06-07 21:15:29

by patchwork-bot+netdevbpf

Subject: Re: [PATCH net-next] net: macb: Use devm_platform_get_and_ioremap_resource()

Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Mon, 7 Jun 2021 21:43:54 +0800 you wrote:
> Use devm_platform_get_and_ioremap_resource() to simplify
> code.
>
> Signed-off-by: Yang Yingliang <[email protected]>
> ---
> drivers/net/ethernet/cadence/macb_main.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)

Here is the summary with links:
- [net-next] net: macb: Use devm_platform_get_and_ioremap_resource()
https://git.kernel.org/netdev/net-next/c/809660cbc82d

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html