2021-06-08 06:18:43

by Zou Wei

Subject: [PATCH -next v2] pinctrl: mcp23s08: Fix missing unlock on error in mcp23s08_irq()

Add the missing unlock before return from function mcp23s08_irq()
in the error handling case.

v1-->v2:
remove the "return IRQ_HANDLED" line

Fixes: 897120d41e7a ("pinctrl: mcp23s08: fix race condition in irq handler")
Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Zou Wei <[email protected]>
---
drivers/pinctrl/pinctrl-mcp23s08.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pinctrl/pinctrl-mcp23s08.c b/drivers/pinctrl/pinctrl-mcp23s08.c
index 799d596..d025957 100644
--- a/drivers/pinctrl/pinctrl-mcp23s08.c
+++ b/drivers/pinctrl/pinctrl-mcp23s08.c
@@ -353,7 +353,7 @@ static irqreturn_t mcp23s08_irq(int irq, void *data)

if (intf == 0) {
/* There is no interrupt pending */
- return IRQ_HANDLED;
+ goto unlock;
}

if (mcp_read(mcp, MCP_INTCAP, &intcap))
--
2.6.2

2021-06-09 18:40:50

by Linus Walleij

Subject: Re: [PATCH -next v2] pinctrl: mcp23s08: Fix missing unlock on error in mcp23s08_irq()

On Tue, Jun 8, 2021 at 8:16 AM Zou Wei <[email protected]> wrote:

> Add the missing unlock before return from function mcp23s08_irq()
> in the error handling case.
>
> v1-->v2:
> remove the "return IRQ_HANDLED" line
>
> Fixes: 897120d41e7a ("pinctrl: mcp23s08: fix race condition in irq handler")
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: Zou Wei <[email protected]>

Patch applied.

Yours,
Linus Walleij