2021-06-09 16:39:07

by Rob Herring (Arm)

[permalink] [raw]
Subject: Re: [PATCH v6 7/8] dt-bindings: Add common bindings for ARM and RISC-V idle states

On Wed, 09 Jun 2021 17:57:14 +0530, Anup Patel wrote:
> The RISC-V CPU idle states will be described in under the
> /cpus/idle-states DT node in the same way as ARM CPU idle
> states.
>
> This patch adds common bindings documentation for both ARM
> and RISC-V idle states.
>
> Signed-off-by: Anup Patel <[email protected]>
> Reviewed-by: Rob Herring <[email protected]>
> ---
> .../bindings/{arm => cpu}/idle-states.yaml | 228 ++++++++++++++++--
> .../devicetree/bindings/riscv/cpus.yaml | 6 +
> 2 files changed, 217 insertions(+), 17 deletions(-)
> rename Documentation/devicetree/bindings/{arm => cpu}/idle-states.yaml (74%)
>

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:

\ndoc reference errors (make refcheckdocs):
Warning: Documentation/devicetree/bindings/arm/msm/qcom,idle-state.txt references a file that doesn't exist: Documentation/devicetree/bindings/arm/idle-states.yaml
Warning: Documentation/devicetree/bindings/arm/psci.yaml references a file that doesn't exist: Documentation/devicetree/bindings/arm/idle-states.yaml
Documentation/devicetree/bindings/arm/msm/qcom,idle-state.txt: Documentation/devicetree/bindings/arm/idle-states.yaml
Documentation/devicetree/bindings/arm/psci.yaml: Documentation/devicetree/bindings/arm/idle-states.yaml

See https://patchwork.ozlabs.org/patch/1489849

This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit.


2021-06-10 04:26:07

by Anup Patel

[permalink] [raw]
Subject: Re: [PATCH v6 7/8] dt-bindings: Add common bindings for ARM and RISC-V idle states

On Wed, Jun 9, 2021 at 9:46 PM Rob Herring <[email protected]> wrote:
>
> On Wed, 09 Jun 2021 17:57:14 +0530, Anup Patel wrote:
> > The RISC-V CPU idle states will be described in under the
> > /cpus/idle-states DT node in the same way as ARM CPU idle
> > states.
> >
> > This patch adds common bindings documentation for both ARM
> > and RISC-V idle states.
> >
> > Signed-off-by: Anup Patel <[email protected]>
> > Reviewed-by: Rob Herring <[email protected]>
> > ---
> > .../bindings/{arm => cpu}/idle-states.yaml | 228 ++++++++++++++++--
> > .../devicetree/bindings/riscv/cpus.yaml | 6 +
> > 2 files changed, 217 insertions(+), 17 deletions(-)
> > rename Documentation/devicetree/bindings/{arm => cpu}/idle-states.yaml (74%)
> >
>
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
>
> \ndoc reference errors (make refcheckdocs):
> Warning: Documentation/devicetree/bindings/arm/msm/qcom,idle-state.txt references a file that doesn't exist: Documentation/devicetree/bindings/arm/idle-states.yaml
> Warning: Documentation/devicetree/bindings/arm/psci.yaml references a file that doesn't exist: Documentation/devicetree/bindings/arm/idle-states.yaml
> Documentation/devicetree/bindings/arm/msm/qcom,idle-state.txt: Documentation/devicetree/bindings/arm/idle-states.yaml
> Documentation/devicetree/bindings/arm/psci.yaml: Documentation/devicetree/bindings/arm/idle-states.yaml
>
> See https://patchwork.ozlabs.org/patch/1489849
>
> This check can fail if there are any dependencies. The base for a patch
> series is generally the most recent rc1.
>
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:
>
> pip3 install dtschema --upgrade
>
> Please check and re-submit.
>

Sure, I will quickly fix this one and send a v7 revision

Regards,
Anup