2021-06-14 11:42:35

by Guangbin Huang

[permalink] [raw]
Subject: [PATCH V2 net-next 04/11] net: z85230: remove redundant initialization for statics

From: Peng Li <[email protected]>

Should not initialise statics to 0.
According to Documentation/process/volatile-considered-harmful.rst,
the "volatile" type class should not be used, so remove it.

Signed-off-by: Peng Li <[email protected]>
Signed-off-by: Guangbin Huang <[email protected]>

---
Change Log:
V1 -> V2:
1, fix the comments from Andrew, add commit message
about remove volatile.
---


---
drivers/net/wan/z85230.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wan/z85230.c b/drivers/net/wan/z85230.c
index 94ed9a2..f815bb5 100644
--- a/drivers/net/wan/z85230.c
+++ b/drivers/net/wan/z85230.c
@@ -685,7 +685,7 @@ irqreturn_t z8530_interrupt(int irq, void *dev_id)
{
struct z8530_dev *dev=dev_id;
u8 intr;
- static volatile int locker=0;
+ static int locker;
int work=0;
struct z8530_irqhandler *irqs;

--
2.8.1