2021-06-15 03:01:55

by Wenbin Mei (梅文彬)

Subject: [PATCH v1] Change compatiable string for MT8195 mmc host IP

Wenbin Mei (1):
dt-bindings: mmc: change compatiable string for MT8195 mmc host IP

Documentation/devicetree/bindings/mmc/mtk-sd.yaml | 2 ++
1 file changed, 2 insertions(+)

--
1.9.1

2021-06-15 03:02:48

by Wenbin Mei (梅文彬)

Subject: [PATCH v1] dt-bindings: mmc: change compatiable string for MT8195 mmc host IP

MT8195 mmc host IP is compatible with MT8183, and currently it shows:
properties:
compatible:
oneOf:
...
- items:
- const: mediatek,mt8192-mmc
- const: mediatek,mt8195-mmc
- const: mediatek,mt8183-mmc
which means the compatible string in the device tree would be:
compatible = "mediatek,mt8192-mmc", "mediatek,mt8195-mmc",
"mediatek,mt8183-mmc";
The bindings is wrong and that isn't the result we want.
instead we want:
properties:
compatible:
oneOf:
...
- items:
- const: mediatek,mt8192-mmc
- const: mediatek,mt8183-mmc
- items:
- const: mediatek,mt8195-mmc
- const: mediatek,mt8183-mmc
which would give us:
compatible = "mediatek,mt8192-mmc", "mediatek,mt8183-mmc";
and
compatible = "mediatek,mt8195-mmc", "mediatek,mt8183-mmc";

Fixes: eb9cb7227e5c (dt-bindings: mmc: Add compatible for Mediatek MT8195)
Signed-off-by: Wenbin Mei <[email protected]>
---
Documentation/devicetree/bindings/mmc/mtk-sd.yaml | 2 ++
1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
index 8648d48..adaba90 100644
--- a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
+++ b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
@@ -31,6 +31,8 @@ properties:
- const: mediatek,mt2701-mmc
- items:
- const: mediatek,mt8192-mmc
+ - const: mediatek,mt8183-mmc
+ - items:
- const: mediatek,mt8195-mmc
- const: mediatek,mt8183-mmc

--
1.9.1

2021-06-24 20:48:54

by Rob Herring (Arm)

Subject: Re: [PATCH v1] dt-bindings: mmc: change compatiable string for MT8195 mmc host IP

On Tue, 15 Jun 2021 11:00:33 +0800, Wenbin Mei wrote:
> MT8195 mmc host IP is compatible with MT8183, and currently it shows:
> properties:
> compatible:
> oneOf:
> ...
> - items:
> - const: mediatek,mt8192-mmc
> - const: mediatek,mt8195-mmc
> - const: mediatek,mt8183-mmc
> which means the compatible string in the device tree would be:
> compatible = "mediatek,mt8192-mmc", "mediatek,mt8195-mmc",
> "mediatek,mt8183-mmc";
> The bindings is wrong and that isn't the result we want.
> instead we want:
> properties:
> compatible:
> oneOf:
> ...
> - items:
> - const: mediatek,mt8192-mmc
> - const: mediatek,mt8183-mmc
> - items:
> - const: mediatek,mt8195-mmc
> - const: mediatek,mt8183-mmc
> which would give us:
> compatible = "mediatek,mt8192-mmc", "mediatek,mt8183-mmc";
> and
> compatible = "mediatek,mt8195-mmc", "mediatek,mt8183-mmc";
>
> Fixes: eb9cb7227e5c (dt-bindings: mmc: Add compatible for Mediatek MT8195)
> Signed-off-by: Wenbin Mei <[email protected]>
> ---
> Documentation/devicetree/bindings/mmc/mtk-sd.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>

Acked-by: Rob Herring <[email protected]>

2021-06-29 15:42:33

by Ulf Hansson

Subject: Re: [PATCH v1] dt-bindings: mmc: change compatiable string for MT8195 mmc host IP

On Tue, 15 Jun 2021 at 05:01, Wenbin Mei <[email protected]> wrote:
>
> MT8195 mmc host IP is compatible with MT8183, and currently it shows:
> properties:
> compatible:
> oneOf:
> ...
> - items:
> - const: mediatek,mt8192-mmc
> - const: mediatek,mt8195-mmc
> - const: mediatek,mt8183-mmc
> which means the compatible string in the device tree would be:
> compatible = "mediatek,mt8192-mmc", "mediatek,mt8195-mmc",
> "mediatek,mt8183-mmc";
> The bindings is wrong and that isn't the result we want.
> instead we want:
> properties:
> compatible:
> oneOf:
> ...
> - items:
> - const: mediatek,mt8192-mmc
> - const: mediatek,mt8183-mmc
> - items:
> - const: mediatek,mt8195-mmc
> - const: mediatek,mt8183-mmc
> which would give us:
> compatible = "mediatek,mt8192-mmc", "mediatek,mt8183-mmc";
> and
> compatible = "mediatek,mt8195-mmc", "mediatek,mt8183-mmc";
>
> Fixes: eb9cb7227e5c (dt-bindings: mmc: Add compatible for Mediatek MT8195)
> Signed-off-by: Wenbin Mei <[email protected]>

Applied for fixes, thanks!

Kind regards
Uffe


> ---
> Documentation/devicetree/bindings/mmc/mtk-sd.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> index 8648d48..adaba90 100644
> --- a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> +++ b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> @@ -31,6 +31,8 @@ properties:
> - const: mediatek,mt2701-mmc
> - items:
> - const: mediatek,mt8192-mmc
> + - const: mediatek,mt8183-mmc
> + - items:
> - const: mediatek,mt8195-mmc
> - const: mediatek,mt8183-mmc
>
> --
> 1.9.1
>