2021-06-15 06:37:32

by Zou Wei

Subject: [PATCH -next] edac: Convert list_for_each to entry variant

convert list_for_each() to list_for_each_entry() where
applicable.

Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Zou Wei <[email protected]>
---
drivers/edac/edac_device.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/edac/edac_device.c b/drivers/edac/edac_device.c
index 8c4d947..e8b33c3 100644
--- a/drivers/edac/edac_device.c
+++ b/drivers/edac/edac_device.c
@@ -245,13 +245,10 @@ EXPORT_SYMBOL_GPL(edac_device_free_ctl_info);
static struct edac_device_ctl_info *find_edac_device_by_dev(struct device *dev)
{
struct edac_device_ctl_info *edac_dev;
- struct list_head *item;

edac_dbg(0, "\n");

- list_for_each(item, &edac_device_list) {
- edac_dev = list_entry(item, struct edac_device_ctl_info, link);
-
+ list_for_each_entry(edac_dev, &edac_device_list, link) {
if (edac_dev->dev == dev)
return edac_dev;
}
--
2.6.2

2021-06-17 08:24:57

by Borislav Petkov

Subject: Re: [PATCH -next] edac: Convert list_for_each to entry variant

On Tue, Jun 15, 2021 at 02:55:10PM +0800, Zou Wei wrote:
> convert list_for_each() to list_for_each_entry() where
> applicable.

That conversion is applicable to one more place in that file...

--
Regards/Gruss,
Boris.

https://people.kernel.org/tglx/notes-about-netiquette