2021-06-16 09:24:01

by Shaik Sajida Bhanu

[permalink] [raw]
Subject: [PATCH V2] arm64: dts: qcom: sc7180: bus votes for eMMC and SD card

Update peak bandwidth and average bandwidth vote values for eMMC and
SDCard. This patch calculates the new votes as per the comments from
https://lore.kernel.org/patchwork/patch/1399453/#1619566.

Signed-off-by: Shaik Sajida Bhanu <[email protected]>
---

Changes since V1:
- Updated the commit message with proper information.
---
arch/arm64/boot/dts/qcom/sc7180.dtsi | 20 ++++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi
index fb1d9ad..a5d58eb 100644
--- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
@@ -727,15 +727,15 @@
opp-100000000 {
opp-hz = /bits/ 64 <100000000>;
required-opps = <&rpmhpd_opp_low_svs>;
- opp-peak-kBps = <100000 100000>;
- opp-avg-kBps = <100000 50000>;
+ opp-peak-kBps = <1800000 600000>;
+ opp-avg-kBps = <100000 0>;
};

opp-384000000 {
opp-hz = /bits/ 64 <384000000>;
- required-opps = <&rpmhpd_opp_svs_l1>;
- opp-peak-kBps = <600000 900000>;
- opp-avg-kBps = <261438 300000>;
+ required-opps = <&rpmhpd_opp_nom>;
+ opp-peak-kBps = <5400000 1600000>;
+ opp-avg-kBps = <390000 0>;
};
};
};
@@ -2585,15 +2585,15 @@
opp-100000000 {
opp-hz = /bits/ 64 <100000000>;
required-opps = <&rpmhpd_opp_low_svs>;
- opp-peak-kBps = <160000 100000>;
- opp-avg-kBps = <80000 50000>;
+ opp-peak-kBps = <1800000 600000>;
+ opp-avg-kBps = <100000 0>;
};

opp-202000000 {
opp-hz = /bits/ 64 <202000000>;
- required-opps = <&rpmhpd_opp_svs_l1>;
- opp-peak-kBps = <200000 120000>;
- opp-avg-kBps = <100000 60000>;
+ required-opps = <&rpmhpd_opp_nom>;
+ opp-peak-kBps = <5400000 1600000>;
+ opp-avg-kBps = <200000 0>;
};
};
};
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation


2021-06-21 09:00:13

by Georgi Djakov

[permalink] [raw]
Subject: Re: [PATCH V2] arm64: dts: qcom: sc7180: bus votes for eMMC and SD card

On 16.06.21 12:22, Shaik Sajida Bhanu wrote:
> Update peak bandwidth and average bandwidth vote values for eMMC and
> SDCard. This patch calculates the new votes as per the comments from
> https://lore.kernel.org/patchwork/patch/1399453/#1619566.
>
> Signed-off-by: Shaik Sajida Bhanu <[email protected]>

Reviewed-by: Georgi Djakov <[email protected]>

> ---
>
> Changes since V1:
> - Updated the commit message with proper information.
> ---
> arch/arm64/boot/dts/qcom/sc7180.dtsi | 20 ++++++++++----------
> 1 file changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> index fb1d9ad..a5d58eb 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> @@ -727,15 +727,15 @@
> opp-100000000 {
> opp-hz = /bits/ 64 <100000000>;
> required-opps = <&rpmhpd_opp_low_svs>;
> - opp-peak-kBps = <100000 100000>;
> - opp-avg-kBps = <100000 50000>;
> + opp-peak-kBps = <1800000 600000>;
> + opp-avg-kBps = <100000 0>;
> };
>
> opp-384000000 {
> opp-hz = /bits/ 64 <384000000>;
> - required-opps = <&rpmhpd_opp_svs_l1>;
> - opp-peak-kBps = <600000 900000>;
> - opp-avg-kBps = <261438 300000>;
> + required-opps = <&rpmhpd_opp_nom>;
> + opp-peak-kBps = <5400000 1600000>;
> + opp-avg-kBps = <390000 0>;
> };
> };
> };
> @@ -2585,15 +2585,15 @@
> opp-100000000 {
> opp-hz = /bits/ 64 <100000000>;
> required-opps = <&rpmhpd_opp_low_svs>;
> - opp-peak-kBps = <160000 100000>;
> - opp-avg-kBps = <80000 50000>;
> + opp-peak-kBps = <1800000 600000>;
> + opp-avg-kBps = <100000 0>;
> };
>
> opp-202000000 {
> opp-hz = /bits/ 64 <202000000>;
> - required-opps = <&rpmhpd_opp_svs_l1>;
> - opp-peak-kBps = <200000 120000>;
> - opp-avg-kBps = <100000 60000>;
> + required-opps = <&rpmhpd_opp_nom>;
> + opp-peak-kBps = <5400000 1600000>;
> + opp-avg-kBps = <200000 0>;
> };
> };
> };
>