2021-06-18 17:38:23

by zhouchuangao

[permalink] [raw]
Subject: [PATCH] drivers/input/keyboard/cros_ec_keyb: Use kobj_to_dev() API

Use kobj_to_dev() API instead of container_of().

Signed-off-by: zhouchuangao <[email protected]>
---
drivers/input/keyboard/cros_ec_keyb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/input/keyboard/cros_ec_keyb.c b/drivers/input/keyboard/cros_ec_keyb.c
index 38457d9..fc02c54 100644
--- a/drivers/input/keyboard/cros_ec_keyb.c
+++ b/drivers/input/keyboard/cros_ec_keyb.c
@@ -644,7 +644,7 @@ static umode_t cros_ec_keyb_attr_is_visible(struct kobject *kobj,
struct attribute *attr,
int n)
{
- struct device *dev = container_of(kobj, struct device, kobj);
+ struct device *dev = kobj_to_dev(kobj);
struct cros_ec_keyb *ckdev = dev_get_drvdata(dev);

if (attr == &dev_attr_function_row_physmap.attr &&
--
2.7.4


2021-06-19 04:19:45

by Stephen Boyd

[permalink] [raw]
Subject: Re: [PATCH] drivers/input/keyboard/cros_ec_keyb: Use kobj_to_dev() API

Quoting zhouchuangao (2021-06-18 07:08:01)
> Use kobj_to_dev() API instead of container_of().
>
> Signed-off-by: zhouchuangao <[email protected]>
> ---

Reviewed-by: Stephen Boyd <[email protected]>

2021-06-20 05:26:46

by Dmitry Torokhov

[permalink] [raw]
Subject: Re: [PATCH] drivers/input/keyboard/cros_ec_keyb: Use kobj_to_dev() API

On Fri, Jun 18, 2021 at 07:08:01AM -0700, zhouchuangao wrote:
> Use kobj_to_dev() API instead of container_of().
>
> Signed-off-by: zhouchuangao <[email protected]>

Applied, thank you.

--
Dmitry