2021-06-12 09:19:01

by Zou Wei

[permalink] [raw]
Subject: [PATCH -next] clocksource/drivers/arm_global_timer: Make symbol 'gt_clk_rate_change_nb' static

The sparse tool complains as follows:

drivers/clocksource/arm_global_timer.c:54:23: warning:
symbol 'gt_clk_rate_change_nb' was not declared. Should it be static?

This symbol is not used outside of arm_global_timer.c, so marks it static.

Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Zou Wei <[email protected]>
---
drivers/clocksource/arm_global_timer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clocksource/arm_global_timer.c b/drivers/clocksource/arm_global_timer.c
index 60a8047..68b1d14 100644
--- a/drivers/clocksource/arm_global_timer.c
+++ b/drivers/clocksource/arm_global_timer.c
@@ -51,7 +51,7 @@
* the units for all operations.
*/
static void __iomem *gt_base;
-struct notifier_block gt_clk_rate_change_nb;
+static struct notifier_block gt_clk_rate_change_nb;
static u32 gt_psv_new, gt_psv_bck, gt_target_rate;
static int gt_ppi;
static struct clock_event_device __percpu *gt_evt;
--
2.6.2


Subject: [tip: timers/core] clocksource/drivers/arm_global_timer: Make symbol 'gt_clk_rate_change_nb' static

The following commit has been merged into the timers/core branch of tip:

Commit-ID: be534f8ee137b95046d7c53c8200ffdcf05781a7
Gitweb: https://git.kernel.org/tip/be534f8ee137b95046d7c53c8200ffdcf05781a7
Author: Zou Wei <[email protected]>
AuthorDate: Sat, 12 Jun 2021 17:27:26 +08:00
Committer: Daniel Lezcano <[email protected]>
CommitterDate: Wed, 16 Jun 2021 17:33:04 +02:00

clocksource/drivers/arm_global_timer: Make symbol 'gt_clk_rate_change_nb' static

The sparse tool complains as follows:

drivers/clocksource/arm_global_timer.c:54:23: warning:
symbol 'gt_clk_rate_change_nb' was not declared. Should it be static?

This symbol is not used outside of arm_global_timer.c, so mark it static.

Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Zou Wei <[email protected]>
Signed-off-by: Daniel Lezcano <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
---
drivers/clocksource/arm_global_timer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clocksource/arm_global_timer.c b/drivers/clocksource/arm_global_timer.c
index 60a8047..68b1d14 100644
--- a/drivers/clocksource/arm_global_timer.c
+++ b/drivers/clocksource/arm_global_timer.c
@@ -51,7 +51,7 @@
* the units for all operations.
*/
static void __iomem *gt_base;
-struct notifier_block gt_clk_rate_change_nb;
+static struct notifier_block gt_clk_rate_change_nb;
static u32 gt_psv_new, gt_psv_bck, gt_target_rate;
static int gt_ppi;
static struct clock_event_device __percpu *gt_evt;