2021-06-18 10:08:51

by Colin King

Subject: [PATCH] net: bridge: remove redundant continue statement

From: Colin Ian King <[email protected]>

The continue statement at the end of a for-loop has no effect,
invert the if expression and remove the continue.

Addresses-Coverity: ("Continue has no effect")
Signed-off-by: Colin Ian King <[email protected]>
---
net/bridge/br_vlan.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/net/bridge/br_vlan.c b/net/bridge/br_vlan.c
index da3256a3eed0..8789a57af543 100644
--- a/net/bridge/br_vlan.c
+++ b/net/bridge/br_vlan.c
@@ -113,9 +113,7 @@ static void __vlan_add_list(struct net_bridge_vlan *v)
headp = &vg->vlan_list;
list_for_each_prev(hpos, headp) {
vent = list_entry(hpos, struct net_bridge_vlan, vlist);
- if (v->vid < vent->vid)
- continue;
- else
+ if (v->vid >= vent->vid)
break;
}
list_add_rcu(&v->vlist, hpos);
--
2.31.1

2021-06-18 12:31:41

by Nikolay Aleksandrov

Subject: Re: [PATCH] net: bridge: remove redundant continue statement

On 18/06/2021 13:01, Colin King wrote:
> From: Colin Ian King <[email protected]>
>
> The continue statement at the end of a for-loop has no effect,
> invert the if expression and remove the continue.
>
> Addresses-Coverity: ("Continue has no effect")
> Signed-off-by: Colin Ian King <[email protected]>
> ---
> net/bridge/br_vlan.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/net/bridge/br_vlan.c b/net/bridge/br_vlan.c
> index da3256a3eed0..8789a57af543 100644
> --- a/net/bridge/br_vlan.c
> +++ b/net/bridge/br_vlan.c
> @@ -113,9 +113,7 @@ static void __vlan_add_list(struct net_bridge_vlan *v)
> headp = &vg->vlan_list;
> list_for_each_prev(hpos, headp) {
> vent = list_entry(hpos, struct net_bridge_vlan, vlist);
> - if (v->vid < vent->vid)
> - continue;
> - else
> + if (v->vid >= vent->vid)
> break;
> }
> list_add_rcu(&v->vlist, hpos);
>

This should be targeted at net-next. Thanks,
Acked-by: Nikolay Aleksandrov <[email protected]>

2021-06-18 19:52:00

by patchwork-bot+netdevbpf

Subject: Re: [PATCH] net: bridge: remove redundant continue statement

Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Fri, 18 Jun 2021 11:01:55 +0100 you wrote:
> From: Colin Ian King <[email protected]>
>
> The continue statement at the end of a for-loop has no effect,
> invert the if expression and remove the continue.
>
> Addresses-Coverity: ("Continue has no effect")
> Signed-off-by: Colin Ian King <[email protected]>
>
> [...]

Here is the summary with links:
- net: bridge: remove redundant continue statement
https://git.kernel.org/netdev/net-next/c/040c12570e68

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html