2021-05-17 14:09:54

by Yang Yingliang

Subject: [PATCH -next resend] rtc: m41t80: correct function names in rtc-m41t80.c

Fix the following make W=1 kernel build warnings:

drivers/rtc/rtc-m41t80.c:811: warning: expecting prototype for wdt_close(). Prototype was for wdt_release() instead
drivers/rtc/rtc-m41t80.c:830: warning: expecting prototype for notify_sys(). Prototype was for wdt_notify_sys() instead

Signed-off-by: Yang Yingliang <[email protected]>
---
drivers/rtc/rtc-m41t80.c | 20 ++++++++------------
1 file changed, 8 insertions(+), 12 deletions(-)

diff --git a/drivers/rtc/rtc-m41t80.c b/drivers/rtc/rtc-m41t80.c
index 89128fc29ccc..269ec4962db3 100644
--- a/drivers/rtc/rtc-m41t80.c
+++ b/drivers/rtc/rtc-m41t80.c
@@ -599,10 +599,8 @@ static unsigned long wdt_is_open;
static int boot_flag;

/**
- * wdt_ping:
- *
- * Reload counter one with the watchdog timeout. We don't bother reloading
- * the cascade counter.
+ * wdt_ping - Reload counter one with the watchdog timeout.
+ * We don't bother reloading the cascade counter.
*/
static void wdt_ping(void)
{
@@ -638,9 +636,7 @@ static void wdt_ping(void)
}

/**
- * wdt_disable:
- *
- * disables watchdog.
+ * wdt_disable - disables watchdog.
*/
static void wdt_disable(void)
{
@@ -677,7 +673,7 @@ static void wdt_disable(void)
}

/**
- * wdt_write:
+ * wdt_write - write to watchdog.
* @file: file handle to the watchdog
* @buf: buffer to write (unused as data does not matter here
* @count: count of bytes
@@ -703,7 +699,7 @@ static ssize_t wdt_read(struct file *file, char __user *buf,
}

/**
- * wdt_ioctl:
+ * wdt_ioctl - ioctl handler to set watchdog.
* @file: file handle to the device
* @cmd: watchdog command
* @arg: argument pointer
@@ -778,7 +774,7 @@ static long wdt_unlocked_ioctl(struct file *file, unsigned int cmd,
}

/**
- * wdt_open:
+ * wdt_open - open a watchdog.
* @inode: inode of device
* @file: file handle to device
*
@@ -802,7 +798,7 @@ static int wdt_open(struct inode *inode, struct file *file)
}

/**
- * wdt_close:
+ * wdt_release - release a watchdog.
* @inode: inode to board
* @file: file handle to board
*
@@ -815,7 +811,7 @@ static int wdt_release(struct inode *inode, struct file *file)
}

/**
- * notify_sys:
+ * wdt_notify_sys - notify to watchdog.
* @this: our notifier block
* @code: the event being reported
* @unused: unused
--
2.25.1

2021-05-18 20:00:53

by Randy Dunlap

Subject: Re: [PATCH -next resend] rtc: m41t80: correct function names in rtc-m41t80.c

On 5/17/21 4:06 AM, Yang Yingliang wrote:
> Fix the following make W=1 kernel build warnings:
>
> drivers/rtc/rtc-m41t80.c:811: warning: expecting prototype for wdt_close(). Prototype was for wdt_release() instead
> drivers/rtc/rtc-m41t80.c:830: warning: expecting prototype for notify_sys(). Prototype was for wdt_notify_sys() instead
>
> Signed-off-by: Yang Yingliang <[email protected]>
> ---
> drivers/rtc/rtc-m41t80.c | 20 ++++++++------------
> 1 file changed, 8 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/rtc/rtc-m41t80.c b/drivers/rtc/rtc-m41t80.c
> index 89128fc29ccc..269ec4962db3 100644
> --- a/drivers/rtc/rtc-m41t80.c
> +++ b/drivers/rtc/rtc-m41t80.c

Reviewed-by: Randy Dunlap <[email protected]>

thanks.

--
~Randy

2021-06-20 20:21:55

by Alexandre Belloni

Subject: Re: [PATCH -next resend] rtc: m41t80: correct function names in rtc-m41t80.c

On Mon, 17 May 2021 19:06:41 +0800, Yang Yingliang wrote:
> Fix the following make W=1 kernel build warnings:
>
> drivers/rtc/rtc-m41t80.c:811: warning: expecting prototype for wdt_close(). Prototype was for wdt_release() instead
> drivers/rtc/rtc-m41t80.c:830: warning: expecting prototype for notify_sys(). Prototype was for wdt_notify_sys() instead

Applied, thanks!

[1/1] rtc: m41t80: correct function names in rtc-m41t80.c
commit: b958da7919e2c325ba8c6e34c947f745e5c66cef

Best regards,
--
Alexandre Belloni <[email protected]>