Hi,
This is a v2 with only minor changes:
1. Drop patches which landed in mainline.
2. Add acks.
3. Rebase max17040 power supply (dtschema conversion).
Patches are independent and there are no external dependencies, so
please pick up freely.
Best regards,
Krzysztof
Krzysztof Kozlowski (7):
mfd: sec-irq: Do not enforce (incorrect) interrupt trigger type
mfd: max77686: Do not enforce (incorrect) interrupt trigger type
mfd: max77693: Do not enforce (incorrect) interrupt trigger type
mfd: max14577: Do not enforce (incorrect) interrupt trigger type
rtc: max77686: Do not enforce (incorrect) interrupt trigger type
power: supply: max17042: Do not enforce (incorrect) interrupt trigger
type
power: supply: max17040: Do not enforce (incorrect) interrupt trigger
type
.../devicetree/bindings/clock/maxim,max77686.txt | 4 ++--
Documentation/devicetree/bindings/mfd/max14577.txt | 4 ++--
Documentation/devicetree/bindings/mfd/max77686.txt | 2 +-
Documentation/devicetree/bindings/mfd/max77693.txt | 2 +-
.../bindings/power/supply/maxim,max17040.yaml | 2 +-
.../devicetree/bindings/regulator/max77686.txt | 2 +-
drivers/mfd/max14577.c | 6 +++---
drivers/mfd/max77686.c | 3 +--
drivers/mfd/max77693.c | 12 ++++--------
drivers/mfd/sec-irq.c | 3 +--
drivers/power/supply/max17040_battery.c | 4 +---
drivers/power/supply/max17042_battery.c | 2 +-
drivers/rtc/rtc-max77686.c | 4 ++--
13 files changed, 21 insertions(+), 29 deletions(-)
--
2.27.0
From: Krzysztof Kozlowski <[email protected]>
Interrupt line can be configured on different hardware in different way,
even inverted. Therefore driver should not enforce specific trigger
type - edge falling - but instead rely on Devicetree to configure it.
The Maxim 17047/77693 datasheets describe the interrupt line as active
low with a requirement of acknowledge from the CPU therefore the edge
falling is not correct.
The interrupt line is shared between PMIC and RTC driver, so using level
sensitive interrupt is here especially important to avoid races. With
an edge configuration in case if first PMIC signals interrupt followed
shortly after by the RTC, the interrupt might not be yet cleared/acked
thus the second one would not be noticed.
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
Changes since v1:
1. None
---
drivers/power/supply/max17042_battery.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/power/supply/max17042_battery.c b/drivers/power/supply/max17042_battery.c
index 1d7326cd8fc6..ce2041b30a06 100644
--- a/drivers/power/supply/max17042_battery.c
+++ b/drivers/power/supply/max17042_battery.c
@@ -1104,7 +1104,7 @@ static int max17042_probe(struct i2c_client *client,
}
if (client->irq) {
- unsigned int flags = IRQF_TRIGGER_FALLING | IRQF_ONESHOT;
+ unsigned int flags = IRQF_ONESHOT;
/*
* On ACPI systems the IRQ may be handled by ACPI-event code,
--
2.27.0
On Wed, 26 May 2021, Krzysztof Kozlowski wrote:
> Hi,
>
> This is a v2 with only minor changes:
> 1. Drop patches which landed in mainline.
> 2. Add acks.
> 3. Rebase max17040 power supply (dtschema conversion).
>
> Patches are independent and there are no external dependencies, so
> please pick up freely.
>
> Best regards,
> Krzysztof
>
>
> Krzysztof Kozlowski (7):
> mfd: sec-irq: Do not enforce (incorrect) interrupt trigger type
> mfd: max77686: Do not enforce (incorrect) interrupt trigger type
> mfd: max77693: Do not enforce (incorrect) interrupt trigger type
> mfd: max14577: Do not enforce (incorrect) interrupt trigger type
> rtc: max77686: Do not enforce (incorrect) interrupt trigger type
> power: supply: max17042: Do not enforce (incorrect) interrupt trigger
> type
> power: supply: max17040: Do not enforce (incorrect) interrupt trigger
> type
MFD patches (at least) do not apply.
Please rebase and resubmit with my:
For my own reference (apply this as-is to your sign-off block):
Acked-for-MFD-by: Lee Jones <[email protected]>
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
On 01/06/2021 17:41, Lee Jones wrote:
> On Wed, 26 May 2021, Krzysztof Kozlowski wrote:
>
>> Hi,
>>
>> This is a v2 with only minor changes:
>> 1. Drop patches which landed in mainline.
>> 2. Add acks.
>> 3. Rebase max17040 power supply (dtschema conversion).
>>
>> Patches are independent and there are no external dependencies, so
>> please pick up freely.
>>
>> Best regards,
>> Krzysztof
>>
>>
>> Krzysztof Kozlowski (7):
>> mfd: sec-irq: Do not enforce (incorrect) interrupt trigger type
>> mfd: max77686: Do not enforce (incorrect) interrupt trigger type
>> mfd: max77693: Do not enforce (incorrect) interrupt trigger type
>> mfd: max14577: Do not enforce (incorrect) interrupt trigger type
>> rtc: max77686: Do not enforce (incorrect) interrupt trigger type
>> power: supply: max17042: Do not enforce (incorrect) interrupt trigger
>> type
>> power: supply: max17040: Do not enforce (incorrect) interrupt trigger
>> type
>
> MFD patches (at least) do not apply.
>
> Please rebase and resubmit with my:
>
> For my own reference (apply this as-is to your sign-off block):
>
> Acked-for-MFD-by: Lee Jones <[email protected]>
I'll resend the MFD part.
For the RTC and power, I hope these apply still cleanly.
Best regards,
Krzysztof
Hi,
On Wed, May 26, 2021 at 01:20:35PM -0400, Krzysztof Kozlowski wrote:
> From: Krzysztof Kozlowski <[email protected]>
>
> Interrupt line can be configured on different hardware in different way,
> even inverted. Therefore driver should not enforce specific trigger
> type - edge falling - but instead rely on Devicetree to configure it.
>
> The Maxim 17047/77693 datasheets describe the interrupt line as active
> low with a requirement of acknowledge from the CPU therefore the edge
> falling is not correct.
>
> The interrupt line is shared between PMIC and RTC driver, so using level
> sensitive interrupt is here especially important to avoid races. With
> an edge configuration in case if first PMIC signals interrupt followed
> shortly after by the RTC, the interrupt might not be yet cleared/acked
> thus the second one would not be noticed.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
>
> ---
>
> Changes since v1:
> 1. None
> ---
Thanks, queued.
-- Sebastian
> drivers/power/supply/max17042_battery.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/power/supply/max17042_battery.c b/drivers/power/supply/max17042_battery.c
> index 1d7326cd8fc6..ce2041b30a06 100644
> --- a/drivers/power/supply/max17042_battery.c
> +++ b/drivers/power/supply/max17042_battery.c
> @@ -1104,7 +1104,7 @@ static int max17042_probe(struct i2c_client *client,
> }
>
> if (client->irq) {
> - unsigned int flags = IRQF_TRIGGER_FALLING | IRQF_ONESHOT;
> + unsigned int flags = IRQF_ONESHOT;
>
> /*
> * On ACPI systems the IRQ may be handled by ACPI-event code,
> --
> 2.27.0
>
On Wed, 26 May 2021 13:20:29 -0400, Krzysztof Kozlowski wrote:
> This is a v2 with only minor changes:
> 1. Drop patches which landed in mainline.
> 2. Add acks.
> 3. Rebase max17040 power supply (dtschema conversion).
>
> Patches are independent and there are no external dependencies, so
> please pick up freely.
>
> [...]
Applied, thanks!
[5/7] rtc: max77686: Do not enforce (incorrect) interrupt trigger type
commit: 742b0d7e15c333303daad4856de0764f4bc83601
Best regards,
--
Alexandre Belloni <[email protected]>