2021-06-30 10:02:42

by Ismail, Mohammad Athari

Subject: [PATCH v2 net] net: stmmac: Terminate FPE workqueue in suspend

From: Mohammad Athari Bin Ismail <[email protected]>

Add stmmac_fpe_stop_wq() in stmmac_suspend() to terminate FPE workqueue
during suspend. So, in suspend mode, there will be no FPE workqueue
available. Without this fix, new additional FPE workqueue will be created
in every suspend->resume cycle.

Fixes: 5a5586112b92 ("net: stmmac: support FPE link partner hand-shaking procedure")
Signed-off-by: Mohammad Athari Bin Ismail <[email protected]>
---
v2 changelog:
- Removed [email protected] from email cc list.
---
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
index c87202cbd3d6..796ad594543d 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
@@ -7170,6 +7170,7 @@ int stmmac_suspend(struct device *dev)
priv->plat->rx_queues_to_use, false);

stmmac_fpe_handshake(priv, false);
+ stmmac_fpe_stop_wq(priv);
}

priv->speed = SPEED_UNKNOWN;
--
2.17.1

2021-07-01 21:02:42

by patchwork-bot+netdevbpf

Subject: Re: [PATCH v2 net] net: stmmac: Terminate FPE workqueue in suspend

Hello:

This patch was applied to netdev/net.git (refs/heads/master):

On Wed, 30 Jun 2021 17:59:35 +0800 you wrote:
> From: Mohammad Athari Bin Ismail <[email protected]>
>
> Add stmmac_fpe_stop_wq() in stmmac_suspend() to terminate FPE workqueue
> during suspend. So, in suspend mode, there will be no FPE workqueue
> available. Without this fix, new additional FPE workqueue will be created
> in every suspend->resume cycle.
>
> [...]

Here is the summary with links:
- [v2,net] net: stmmac: Terminate FPE workqueue in suspend
https://git.kernel.org/netdev/net/c/6b28a86d6c0b

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html