2021-07-02 15:24:10

by Rodrigo Campos

[permalink] [raw]
Subject: [PATCH] Documentation: seccomp: Fix typo in user notification

The close on exec flag is O_CLOEXEC, not O_EXEC. This patch just fixes
the typo.

Suggested-by: Christian Brauner <[email protected]>
Signed-off-by: Rodrigo Campos <[email protected]>
---
Documentation/userspace-api/seccomp_filter.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/userspace-api/seccomp_filter.rst b/Documentation/userspace-api/seccomp_filter.rst
index d61219889e49..539e9d4a4860 100644
--- a/Documentation/userspace-api/seccomp_filter.rst
+++ b/Documentation/userspace-api/seccomp_filter.rst
@@ -263,7 +263,7 @@ Userspace can also add file descriptors to the notifying process via
``ioctl(SECCOMP_IOCTL_NOTIF_ADDFD)``. The ``id`` member of
``struct seccomp_notif_addfd`` should be the same ``id`` as in
``struct seccomp_notif``. The ``newfd_flags`` flag may be used to set flags
-like O_EXEC on the file descriptor in the notifying process. If the supervisor
+like O_CLOEXEC on the file descriptor in the notifying process. If the supervisor
wants to inject the file descriptor with a specific number, the
``SECCOMP_ADDFD_FLAG_SETFD`` flag can be used, and set the ``newfd`` member to
the specific number to use. If that file descriptor is already open in the
--
2.30.2


2021-07-02 15:24:18

by Christian Brauner

[permalink] [raw]
Subject: Re: [PATCH] Documentation: seccomp: Fix typo in user notification

On Fri, Jul 02, 2021 at 05:19:27PM +0200, Rodrigo Campos wrote:
> The close on exec flag is O_CLOEXEC, not O_EXEC. This patch just fixes
> the typo.
>
> Suggested-by: Christian Brauner <[email protected]>
> Signed-off-by: Rodrigo Campos <[email protected]>
> ---

Acked-by: Christian Brauner <[email protected]>

2021-07-02 17:42:27

by Kees Cook

[permalink] [raw]
Subject: Re: [PATCH] Documentation: seccomp: Fix typo in user notification

On Fri, 2 Jul 2021 17:19:27 +0200, Rodrigo Campos wrote:
> The close on exec flag is O_CLOEXEC, not O_EXEC. This patch just fixes
> the typo.

Applied to for-next/seccomp, thanks!

[1/1] Documentation: seccomp: Fix typo in user notification
https://git.kernel.org/kees/c/19d67694745c

--
Kees Cook