2021-08-16 21:08:16

by Randy Dunlap

Subject: [PATCH] ARC: export clear_user_page() for modules

0day bot reports a build error:
ERROR: modpost: "clear_user_page" [drivers/media/v4l2-core/videobuf-dma-sg.ko] undefined!
so export it in arch/arc/ to fix the build error.

In most ARCHes, clear_user_page() is a macro. OTOH, in a few
ARCHes it is a function and needs to be exported.
PowerPC exported it in 2004. It looks like nds32 and nios2
still need to have it exported.

Fixes: 4102b53392d63 ("ARC: [mm] Aliasing VIPT dcache support 2/4")
Signed-off-by: Randy Dunlap <[email protected]>
Reported-by: kernel test robot <[email protected]>
Cc: Guenter Roeck <[email protected]>
Cc: Vineet Gupta <[email protected]>
Cc: [email protected]
---
arch/arc/mm/cache.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-next-20210816.orig/arch/arc/mm/cache.c
+++ linux-next-20210816/arch/arc/mm/cache.c
@@ -1041,7 +1041,7 @@ void clear_user_page(void *to, unsigned
clear_page(to);
clear_bit(PG_dc_clean, &page->flags);
}
-
+EXPORT_SYMBOL(clear_user_page);

/**********************************************************************
* Explicit Cache flush request from user space via syscall

2021-08-16 22:01:50

by Vineet Gupta

Subject: Re: [PATCH] ARC: export clear_user_page() for modules

On 8/16/21 2:05 PM, Randy Dunlap wrote:
> 0day bot reports a build error:
> ERROR: modpost: "clear_user_page" [drivers/media/v4l2-core/videobuf-dma-sg.ko] undefined!
> so export it in arch/arc/ to fix the build error.
>
> In most ARCHes, clear_user_page() is a macro. OTOH, in a few
> ARCHes it is a function and needs to be exported.
> PowerPC exported it in 2004. It looks like nds32 and nios2
> still need to have it exported.
>
> Fixes: 4102b53392d63 ("ARC: [mm] Aliasing VIPT dcache support 2/4")
> Signed-off-by: Randy Dunlap <[email protected]>
> Reported-by: kernel test robot <[email protected]>
> Cc: Guenter Roeck <[email protected]>
> Cc: Vineet Gupta <[email protected]>
> Cc: [email protected]

Thx for the fix. Added for 5.16 !

-Vineet

> ---
> arch/arc/mm/cache.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-next-20210816.orig/arch/arc/mm/cache.c
> +++ linux-next-20210816/arch/arc/mm/cache.c
> @@ -1041,7 +1041,7 @@ void clear_user_page(void *to, unsigned
> clear_page(to);
> clear_bit(PG_dc_clean, &page->flags);
> }
> -
> +EXPORT_SYMBOL(clear_user_page);
>
> /**********************************************************************
> * Explicit Cache flush request from user space via syscall
>
> _______________________________________________
> linux-snps-arc mailing list
> [email protected]
> http://lists.infradead.org/mailman/listinfo/linux-snps-arc