2021-07-12 14:39:50

by Colin King

Subject: [PATCH] octeontx2-pf: Fix uninitialized boolean variable pps

From: Colin Ian King <[email protected]>

In the case where act->id is FLOW_ACTION_POLICE and also
act->police.rate_bytes_ps > 0 or act->police.rate_pkt_ps is not > 0
the boolean variable pps contains an uninitialized value when
function otx2_tc_act_set_police is called. Fix this by initializing
pps to false.

Addresses-Coverity: ("Uninitialized scalar variable)"
Fixes: 68fbff68dbea ("octeontx2-pf: Add police action for TC flower")
Signed-off-by: Colin Ian King <[email protected]>
---
drivers/net/ethernet/marvell/octeontx2/nic/otx2_tc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_tc.c b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_tc.c
index 905fc02a7dfe..972b202b9884 100644
--- a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_tc.c
+++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_tc.c
@@ -288,7 +288,7 @@ static int otx2_tc_parse_actions(struct otx2_nic *nic,
struct otx2_nic *priv;
u32 burst, mark = 0;
u8 nr_police = 0;
- bool pps;
+ bool pps = false;
u64 rate;
int i;

--
2.31.1

2021-07-12 18:31:00

by patchwork-bot+netdevbpf

Subject: Re: [PATCH] octeontx2-pf: Fix uninitialized boolean variable pps

Hello:

This patch was applied to netdev/net.git (refs/heads/master):

On Mon, 12 Jul 2021 15:37:50 +0100 you wrote:
> From: Colin Ian King <[email protected]>
>
> In the case where act->id is FLOW_ACTION_POLICE and also
> act->police.rate_bytes_ps > 0 or act->police.rate_pkt_ps is not > 0
> the boolean variable pps contains an uninitialized value when
> function otx2_tc_act_set_police is called. Fix this by initializing
> pps to false.
>
> [...]

Here is the summary with links:
- octeontx2-pf: Fix uninitialized boolean variable pps
https://git.kernel.org/netdev/net/c/71ce9d92fc70

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html