2021-07-15 17:09:50

by Matthias Brugger

[permalink] [raw]
Subject: [PATCH] arm64: dts: rockchip: Disable CDN DP on Pinebook Pro

From: Matthias Brugger <[email protected]>

The CDN DP needs a PHY and a extcon to work correctly. But no extcon is
provided by the device-tree, which leads to an error:
cdn-dp fec00000.dp: [drm:cdn_dp_probe [rockchipdrm]] *ERROR* missing extcon or phy
cdn-dp: probe of fec00000.dp failed with error -22

Disable the CDN DP to make graphic work on the Pinebook Pro.

Reported-by: Guillaume Gardet <[email protected]>
Signed-off-by: Matthias Brugger <[email protected]>

---

arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts | 4 ----
1 file changed, 4 deletions(-)

diff --git a/arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts b/arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts
index 2b5f001ff4a6..9e5d07f5712e 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts
@@ -385,10 +385,6 @@ mains_charger: dc-charger {
};
};

-&cdn_dp {
- status = "okay";
-};
-
&cpu_b0 {
cpu-supply = <&vdd_cpu_b>;
};
--
2.31.1


2021-07-17 21:53:24

by Heiko Stuebner

[permalink] [raw]
Subject: Re: [PATCH] arm64: dts: rockchip: Disable CDN DP on Pinebook Pro

On Thu, 15 Jul 2021 18:41:01 +0200, [email protected] wrote:
> The CDN DP needs a PHY and a extcon to work correctly. But no extcon is
> provided by the device-tree, which leads to an error:
> cdn-dp fec00000.dp: [drm:cdn_dp_probe [rockchipdrm]] *ERROR* missing extcon or phy
> cdn-dp: probe of fec00000.dp failed with error -22
>
> Disable the CDN DP to make graphic work on the Pinebook Pro.

Applied, thanks!

[1/1] arm64: dts: rockchip: Disable CDN DP on Pinebook Pro
commit: 714b35da2b6eace13bfe23ae02330e3b6a2ea4e7

Best regards,
--
Heiko Stuebner <[email protected]>

2021-10-23 18:41:37

by Siva Mahadevan

[permalink] [raw]
Subject: Re: [PATCH] arm64: dts: rockchip: Disable CDN DP on Pinebook Pro

Heiko Stuebner wrote:
> On Thu, 15 Jul 2021 18:41:01 +0200, [email protected] wrote:
> > The CDN DP needs a PHY and a extcon to work correctly. But no extcon is
> > provided by the device-tree, which leads to an error:
> > cdn-dp fec00000.dp: [drm:cdn_dp_probe [rockchipdrm]] *ERROR* missing extcon or phy
> > cdn-dp: probe of fec00000.dp failed with error -22
> >
> > Disable the CDN DP to make graphic work on the Pinebook Pro.
>
> Applied, thanks!
>
> [1/1] arm64: dts: rockchip: Disable CDN DP on Pinebook Pro
> commit: 714b35da2b6eace13bfe23ae02330e3b6a2ea4e7
>
> Best regards,
> --
> Heiko Stuebner <[email protected]>

Will this patch be submitted to mainline? I can confirm on my pinebook
pro that this solves the issue.