2021-07-29 12:05:50

by Rajendra Nayak

[permalink] [raw]
Subject: [PATCH v2 0/3] nvmem: qfprom: Add binding updates and power-domain handling

v2:
* pm_runtime calls made unconditionally, should work even without the power-domains property in DT
* Added the missing pm_runtime_disable() handling
* DT patch rebased on msm/for-next

--
qfprom devices on sc7280 have an additional requirement to vote on a power-domain
performance state to reliably blow fuses. Add the binding updates and handle this in
the driver, also add the DT node for sc7280 platform.

Rajendra Nayak (3):
dt-bindings: nvmem: qfprom: Add optional power-domains property
nvmem: qfprom: sc7280: Handle the additional power-domains vote
arm64: dts: qcom: sc7280: Add qfprom node

.../devicetree/bindings/nvmem/qcom,qfprom.yaml | 3 +++
arch/arm64/boot/dts/qcom/sc7280.dtsi | 13 +++++++++++
drivers/nvmem/qfprom.c | 26 ++++++++++++++++++++++
3 files changed, 42 insertions(+)

--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation



2021-07-29 12:06:05

by Rajendra Nayak

[permalink] [raw]
Subject: [PATCH v2 3/3] arm64: dts: qcom: sc7280: Add qfprom node

Add the qfprom node and its properties for the sc7280 SoC.

Signed-off-by: Rajendra Nayak <[email protected]>
---
arch/arm64/boot/dts/qcom/sc7280.dtsi | 13 +++++++++++++
1 file changed, 13 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
index 029723a..e87b210 100644
--- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
@@ -442,6 +442,19 @@
#mbox-cells = <2>;
};

+ qfprom: efuse@784000 {
+ compatible = "qcom,sc7280-qfprom", "qcom,qfprom";
+ reg = <0 0x00784000 0 0xa20>,
+ <0 0x00780000 0 0xa20>,
+ <0 0x00782000 0 0x120>,
+ <0 0x00786000 0 0x1fff>;
+ clocks = <&gcc GCC_SEC_CTRL_CLK_SRC>;
+ clock-names = "core";
+ power-domains = <&rpmhpd SC7280_MX>;
+ #address-cells = <1>;
+ #size-cells = <1>;
+ };
+
sdhc_1: sdhci@7c4000 {
compatible = "qcom,sc7280-sdhci", "qcom,sdhci-msm-v5";
status = "disabled";
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation


2021-07-29 16:25:56

by Doug Anderson

[permalink] [raw]
Subject: Re: [PATCH v2 3/3] arm64: dts: qcom: sc7280: Add qfprom node

Hi,

On Thu, Jul 29, 2021 at 5:01 AM Rajendra Nayak <[email protected]> wrote:
>
> Add the qfprom node and its properties for the sc7280 SoC.
>
> Signed-off-by: Rajendra Nayak <[email protected]>
> ---
> arch/arm64/boot/dts/qcom/sc7280.dtsi | 13 +++++++++++++
> 1 file changed, 13 insertions(+)

Peachy! I guess a future patch will add things like USB2 trim and GPU
speed bin definitions?

Reviewed-by: Douglas Anderson <[email protected]>

2021-07-30 06:00:31

by Rajendra Nayak

[permalink] [raw]
Subject: Re: [PATCH v2 3/3] arm64: dts: qcom: sc7280: Add qfprom node



On 7/29/2021 9:54 PM, Doug Anderson wrote:
> Hi,
>
> On Thu, Jul 29, 2021 at 5:01 AM Rajendra Nayak <[email protected]> wrote:
>>
>> Add the qfprom node and its properties for the sc7280 SoC.
>>
>> Signed-off-by: Rajendra Nayak <[email protected]>
>> ---
>> arch/arm64/boot/dts/qcom/sc7280.dtsi | 13 +++++++++++++
>> 1 file changed, 13 insertions(+)
>
> Peachy! I guess a future patch will add things like USB2 trim and GPU
> speed bin definitions?

Right, I left those out for a future patch.

>
> Reviewed-by: Douglas Anderson <[email protected]>

Thanks
>

--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation