2021-08-04 21:33:49

by Raag Jadav

Subject: [PATCH v2 1/2] arm64: dts: ls1046a: fix eeprom entries

ls1046afrwy and ls1046ardb boards have CAT24C04[1] and CAT24C05[2]
eeproms respectively. Both are 4Kb (512 bytes) in size,
and compatible with AT24C04[3].
Remove multi-address entries, as both the boards have a single chip each.

[1] https://www.onsemi.com/pdf/datasheet/cat24c01-d.pdf
[2] https://www.onsemi.com/pdf/datasheet/cat24c03-d.pdf
[3] https://ww1.microchip.com/downloads/en/DeviceDoc/doc0180.pdf

Signed-off-by: Raag Jadav <[email protected]>
---
arch/arm64/boot/dts/freescale/fsl-ls1046a-frwy.dts | 8 +-------
arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts | 7 +------
2 files changed, 2 insertions(+), 13 deletions(-)

diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a-frwy.dts b/arch/arm64/boot/dts/freescale/fsl-ls1046a-frwy.dts
index db3d303..6d22efb 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1046a-frwy.dts
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a-frwy.dts
@@ -83,15 +83,9 @@
};

eeprom@52 {
- compatible = "atmel,24c512";
+ compatible = "onnn,cat24c04", "atmel,24c04";
reg = <0x52>;
};
-
- eeprom@53 {
- compatible = "atmel,24c512";
- reg = <0x53>;
- };
-
};
};
};
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts b/arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts
index 60acdf0..7025aad 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts
@@ -59,14 +59,9 @@
};

eeprom@52 {
- compatible = "atmel,24c512";
+ compatible = "onnn,cat24c05", "atmel,24c04";
reg = <0x52>;
};
-
- eeprom@53 {
- compatible = "atmel,24c512";
- reg = <0x53>;
- };
};

&i2c3 {
--
2.7.4

2021-08-07 00:25:11

by Leo Li

Subject: Re: [PATCH v2 1/2] arm64: dts: ls1046a: fix eeprom entries

On Wed, Aug 4, 2021 at 4:32 PM Raag Jadav <[email protected]> wrote:
>
> ls1046afrwy and ls1046ardb boards have CAT24C04[1] and CAT24C05[2]
> eeproms respectively. Both are 4Kb (512 bytes) in size,
> and compatible with AT24C04[3].
> Remove multi-address entries, as both the boards have a single chip each.
>
> [1] https://www.onsemi.com/pdf/datasheet/cat24c01-d.pdf
> [2] https://www.onsemi.com/pdf/datasheet/cat24c03-d.pdf
> [3] https://ww1.microchip.com/downloads/en/DeviceDoc/doc0180.pdf
>
> Signed-off-by: Raag Jadav <[email protected]>

Acked-by: Li Yang <[email protected]>
> ---
> arch/arm64/boot/dts/freescale/fsl-ls1046a-frwy.dts | 8 +-------
> arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts | 7 +------
> 2 files changed, 2 insertions(+), 13 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a-frwy.dts b/arch/arm64/boot/dts/freescale/fsl-ls1046a-frwy.dts
> index db3d303..6d22efb 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1046a-frwy.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a-frwy.dts
> @@ -83,15 +83,9 @@
> };
>
> eeprom@52 {
> - compatible = "atmel,24c512";
> + compatible = "onnn,cat24c04", "atmel,24c04";
> reg = <0x52>;
> };
> -
> - eeprom@53 {
> - compatible = "atmel,24c512";
> - reg = <0x53>;
> - };
> -
> };
> };
> };
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts b/arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts
> index 60acdf0..7025aad 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts
> @@ -59,14 +59,9 @@
> };
>
> eeprom@52 {
> - compatible = "atmel,24c512";
> + compatible = "onnn,cat24c05", "atmel,24c04";
> reg = <0x52>;
> };
> -
> - eeprom@53 {
> - compatible = "atmel,24c512";
> - reg = <0x53>;
> - };
> };
>
> &i2c3 {
> --
> 2.7.4
>

2021-08-09 07:49:17

by Shawn Guo

Subject: Re: [PATCH v2 1/2] arm64: dts: ls1046a: fix eeprom entries

On Thu, Aug 05, 2021 at 12:54:45AM +0530, Raag Jadav wrote:
> ls1046afrwy and ls1046ardb boards have CAT24C04[1] and CAT24C05[2]
> eeproms respectively. Both are 4Kb (512 bytes) in size,
> and compatible with AT24C04[3].
> Remove multi-address entries, as both the boards have a single chip each.
>
> [1] https://www.onsemi.com/pdf/datasheet/cat24c01-d.pdf
> [2] https://www.onsemi.com/pdf/datasheet/cat24c03-d.pdf
> [3] https://ww1.microchip.com/downloads/en/DeviceDoc/doc0180.pdf
>
> Signed-off-by: Raag Jadav <[email protected]>

Applied, thanks!