2021-08-05 14:22:24

by Tiezhu Yang

Subject: [PATCH] f2fs: Kconfig: clean up config options about compression

In fs/f2fs/Kconfig, F2FS_FS_LZ4HC depends on F2FS_FS_LZ4 and F2FS_FS_LZ4
depends on F2FS_FS_COMPRESSION, so no need to make F2FS_FS_LZ4HC depends
on F2FS_FS_COMPRESSION explicitly, remove the redudant "depends on", do
the similar thing for F2FS_FS_LZORLE.

At the same time, it is better to move F2FS_FS_LZORLE next to F2FS_FS_LZO,
it looks like a little more clear when make menuconfig, the location of
"LZO-RLE compression support" is under "LZO compression support" instead
of "F2FS compression feature".

Without this patch:

F2FS compression feature
LZO compression support
LZ4 compression support
LZ4HC compression support
ZSTD compression support
LZO-RLE compression support

With this patch:

F2FS compression feature
LZO compression support
LZO-RLE compression support
LZ4 compression support
LZ4HC compression support
ZSTD compression support

Signed-off-by: Tiezhu Yang <[email protected]>
---
fs/f2fs/Kconfig | 16 +++++++---------
1 file changed, 7 insertions(+), 9 deletions(-)

diff --git a/fs/f2fs/Kconfig b/fs/f2fs/Kconfig
index 7669de7..2ac026f 100644
--- a/fs/f2fs/Kconfig
+++ b/fs/f2fs/Kconfig
@@ -105,6 +105,13 @@ config F2FS_FS_LZO
help
Support LZO compress algorithm, if unsure, say Y.

+config F2FS_FS_LZORLE
+ bool "LZO-RLE compression support"
+ depends on F2FS_FS_LZO
+ default y
+ help
+ Support LZO-RLE compress algorithm, if unsure, say Y.
+
config F2FS_FS_LZ4
bool "LZ4 compression support"
depends on F2FS_FS_COMPRESSION
@@ -114,7 +121,6 @@ config F2FS_FS_LZ4

config F2FS_FS_LZ4HC
bool "LZ4HC compression support"
- depends on F2FS_FS_COMPRESSION
depends on F2FS_FS_LZ4
default y
help
@@ -127,11 +133,3 @@ config F2FS_FS_ZSTD
default y
help
Support ZSTD compress algorithm, if unsure, say Y.
-
-config F2FS_FS_LZORLE
- bool "LZO-RLE compression support"
- depends on F2FS_FS_COMPRESSION
- depends on F2FS_FS_LZO
- default y
- help
- Support LZO-RLE compress algorithm, if unsure, say Y.
--
2.1.0

2021-08-05 14:46:55

by Chao Yu

Subject: Re: [PATCH] f2fs: Kconfig: clean up config options about compression

On 2021/8/5 21:30, Tiezhu Yang wrote:
> In fs/f2fs/Kconfig, F2FS_FS_LZ4HC depends on F2FS_FS_LZ4 and F2FS_FS_LZ4
> depends on F2FS_FS_COMPRESSION, so no need to make F2FS_FS_LZ4HC depends
> on F2FS_FS_COMPRESSION explicitly, remove the redudant "depends on", do
> the similar thing for F2FS_FS_LZORLE.
>
> At the same time, it is better to move F2FS_FS_LZORLE next to F2FS_FS_LZO,
> it looks like a little more clear when make menuconfig, the location of
> "LZO-RLE compression support" is under "LZO compression support" instead
> of "F2FS compression feature".
>
> Without this patch:
>
> F2FS compression feature
> LZO compression support
> LZ4 compression support
> LZ4HC compression support
> ZSTD compression support
> LZO-RLE compression support
>
> With this patch:
>
> F2FS compression feature
> LZO compression support
> LZO-RLE compression support
> LZ4 compression support
> LZ4HC compression support
> ZSTD compression support
>
> Signed-off-by: Tiezhu Yang <[email protected]>

Reviewed-by: Chao Yu <[email protected]>

Thanks,