2021-08-13 07:47:53

by Jiapeng Chong

Subject: [PATCH] pinctrl: renesas: Remove unneeded semicolon

Fix the following coccicheck warnings:

./drivers/pinctrl/renesas/pinctrl-rzg2l.c:1124:2-3: Unneeded semicolon.
./drivers/pinctrl/renesas/pinctrl-rzg2l.c:1114:2-3: Unneeded semicolon.
./drivers/pinctrl/renesas/pinctrl-rzg2l.c:1080:2-3: Unneeded semicolon.

Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Jiapeng Chong <[email protected]>
---
drivers/pinctrl/renesas/pinctrl-rzg2l.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/pinctrl/renesas/pinctrl-rzg2l.c b/drivers/pinctrl/renesas/pinctrl-rzg2l.c
index 9efe3f2..dbf2f52 100644
--- a/drivers/pinctrl/renesas/pinctrl-rzg2l.c
+++ b/drivers/pinctrl/renesas/pinctrl-rzg2l.c
@@ -1077,7 +1077,7 @@ static int rzg2l_pinctrl_register(struct rzg2l_pinctrl *pctrl)
if (ret) {
dev_err(pctrl->dev, "failed to add GPIO chip: %i\n", ret);
return ret;
- };
+ }

return 0;
}
@@ -1111,7 +1111,7 @@ static int rzg2l_pinctrl_probe(struct platform_device *pdev)
ret = PTR_ERR(pctrl->clk);
dev_err(pctrl->dev, "failed to get GPIO clk : %i\n", ret);
return ret;
- };
+ }

spin_lock_init(&pctrl->lock);

@@ -1121,7 +1121,7 @@ static int rzg2l_pinctrl_probe(struct platform_device *pdev)
if (ret) {
dev_err(pctrl->dev, "failed to enable GPIO clk: %i\n", ret);
return ret;
- };
+ }

ret = devm_add_action_or_reset(&pdev->dev, rzg2l_pinctrl_clk_disable,
pctrl->clk);
--
1.8.3.1

2021-08-13 09:20:05

by Geert Uytterhoeven

Subject: Re: [PATCH] pinctrl: renesas: Remove unneeded semicolon

Hi Jiapeng,

On Fri, Aug 13, 2021 at 9:40 AM Jiapeng Chong
<[email protected]> wrote:
> Fix the following coccicheck warnings:
>
> ./drivers/pinctrl/renesas/pinctrl-rzg2l.c:1124:2-3: Unneeded semicolon.
> ./drivers/pinctrl/renesas/pinctrl-rzg2l.c:1114:2-3: Unneeded semicolon.
> ./drivers/pinctrl/renesas/pinctrl-rzg2l.c:1080:2-3: Unneeded semicolon.
>
> Reported-by: Abaci Robot <[email protected]>
> Signed-off-by: Jiapeng Chong <[email protected]>

Thanks!

Reviewed-by: Geert Uytterhoeven <[email protected]>

As this fixes the top commit in my renesas-pinctrl-for-v5.15 branch,
for which I'm about to send a PR soon, I will fold this into the offending
commit.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds