2021-08-03 15:02:40

by Julia Lawall

Subject: [PATCH] powerpc/kexec: fix for_each_child.cocci warning

From: kernel test robot <[email protected]>

for_each_node_by_type should have of_node_put() before return.

Generated by: scripts/coccinelle/iterators/for_each_child.cocci

CC: Sumera Priyadarsini <[email protected]>
Reported-by: kernel test robot <[email protected]>
Signed-off-by: kernel test robot <[email protected]>
---

The code seems to have been this way since the beginning of time. Perhaps
the of_node_put is a no op for this code?

core_64.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

--- a/arch/powerpc/kexec/core_64.c
+++ b/arch/powerpc/kexec/core_64.c
@@ -64,8 +64,10 @@ int default_machine_kexec_prepare(struct
begin = image->segment[i].mem;
end = begin + image->segment[i].memsz;

- if ((begin < high) && (end > low))
+ if ((begin < high) && (end > low)) {
+ of_node_put(node);
return -ETXTBSY;
+ }
}
}

2021-08-18 13:47:20

by Michael Ellerman

Subject: Re: [PATCH] powerpc/kexec: fix for_each_child.cocci warning

On Tue, 3 Aug 2021 16:59:55 +0200 (CEST), Julia Lawall wrote:
> for_each_node_by_type should have of_node_put() before return.
>
> Generated by: scripts/coccinelle/iterators/for_each_child.cocci

Applied to powerpc/next.

[1/1] powerpc/kexec: fix for_each_child.cocci warning
https://git.kernel.org/powerpc/c/c00103abf76fd3916596afd07dd3fdeee0dca15d

cheers