2024-02-26 08:28:39

by Isaku Yamahata

Subject: [PATCH v19 001/130] x86/virt/tdx: Rename _offset to _member for TD_SYSINFO_MAP() macro

From: Kai Huang <[email protected]>

TD_SYSINFO_MAP() macro actually takes the member of the 'struct
tdx_tdmr_sysinfo' as the second argument and uses the offsetof() to
calculate the offset for that member.

Rename the macro argument _offset to _member to reflect this.

Signed-off-by: Kai Huang <[email protected]>
Reviewed-by: Kirill A. Shutemov <[email protected]>
Signed-off-by: Isaku Yamahata <[email protected]>
---
arch/x86/virt/vmx/tdx/tdx.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/x86/virt/vmx/tdx/tdx.c b/arch/x86/virt/vmx/tdx/tdx.c
index 4d6826a76f78..2aee64d2f27f 100644
--- a/arch/x86/virt/vmx/tdx/tdx.c
+++ b/arch/x86/virt/vmx/tdx/tdx.c
@@ -297,9 +297,9 @@ struct field_mapping {
int offset;
};

-#define TD_SYSINFO_MAP(_field_id, _offset) \
+#define TD_SYSINFO_MAP(_field_id, _member) \
{ .field_id = MD_FIELD_ID_##_field_id, \
- .offset = offsetof(struct tdx_tdmr_sysinfo, _offset) }
+ .offset = offsetof(struct tdx_tdmr_sysinfo, _member) }

/* Map TD_SYSINFO fields into 'struct tdx_tdmr_sysinfo': */
static const struct field_mapping fields[] = {
--
2.25.1

2024-03-08 07:26:01

by Binbin Wu

Subject: Re: [PATCH v19 001/130] x86/virt/tdx: Rename _offset to _member for TD_SYSINFO_MAP() macro

On 2/26/2024 4:25 PM, [email protected] wrote:
> From: Kai Huang <[email protected]>
>
> TD_SYSINFO_MAP() macro actually takes the member of the 'struct
> tdx_tdmr_sysinfo' as the second argument and uses the offsetof() to
> calculate the offset for that member.
>
> Rename the macro argument _offset to _member to reflect this.
>
> Signed-off-by: Kai Huang <[email protected]>
> Reviewed-by: Kirill A. Shutemov <[email protected]>
> Signed-off-by: Isaku Yamahata <[email protected]>

Reviewed-by: Binbin Wu <[email protected]>

> ---
> arch/x86/virt/vmx/tdx/tdx.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/x86/virt/vmx/tdx/tdx.c b/arch/x86/virt/vmx/tdx/tdx.c
> index 4d6826a76f78..2aee64d2f27f 100644
> --- a/arch/x86/virt/vmx/tdx/tdx.c
> +++ b/arch/x86/virt/vmx/tdx/tdx.c
> @@ -297,9 +297,9 @@ struct field_mapping {
> int offset;
> };
>
> -#define TD_SYSINFO_MAP(_field_id, _offset) \
> +#define TD_SYSINFO_MAP(_field_id, _member) \
> { .field_id = MD_FIELD_ID_##_field_id, \
> - .offset = offsetof(struct tdx_tdmr_sysinfo, _offset) }
> + .offset = offsetof(struct tdx_tdmr_sysinfo, _member) }
>
> /* Map TD_SYSINFO fields into 'struct tdx_tdmr_sysinfo': */
> static const struct field_mapping fields[] = {

2024-03-08 10:39:02

by Huang, Kai

Subject: Re: [PATCH v19 001/130] x86/virt/tdx: Rename _offset to _member for TD_SYSINFO_MAP() macro

On Fri, 2024-03-08 at 15:25 +0800, Binbin Wu wrote:
>
> On 2/26/2024 4:25 PM, [email protected] wrote:
> > From: Kai Huang <[email protected]>
> >
> > TD_SYSINFO_MAP() macro actually takes the member of the 'struct
> > tdx_tdmr_sysinfo' as the second argument and uses the offsetof() to
> > calculate the offset for that member.
> >
> > Rename the macro argument _offset to _member to reflect this.
> >
> > Signed-off-by: Kai Huang <[email protected]>
> > Reviewed-by: Kirill A. Shutemov <[email protected]>
> > Signed-off-by: Isaku Yamahata <[email protected]>
>
> Reviewed-by: Binbin Wu <[email protected]>
>
>

Thanks for review.

I've sent out the first 5 metadata read patches as a standalone patchset
separately:

https://lore.kernel.org/kvm/[email protected]/

I'll add your Reviewed-by in next version.

(for others please comment there instead, thanks!)