2021-09-02 09:59:53

by Miles Chen

[permalink] [raw]
Subject: [PATCH] clk: imx: use module_platform_driver

Replace builtin_platform_driver_probe with module_platform_driver_probe
because that CONFIG_CLK_IMX8QXP can be set to =m (kernel module).

Cc: Stephen Boyd <[email protected]>
Signed-off-by: Miles Chen <[email protected]>
---
drivers/clk/imx/clk-imx8qxp-lpcg.c | 2 +-
drivers/clk/imx/clk-imx8qxp.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/clk/imx/clk-imx8qxp-lpcg.c b/drivers/clk/imx/clk-imx8qxp-lpcg.c
index d3e905cf867d..b23758083ce5 100644
--- a/drivers/clk/imx/clk-imx8qxp-lpcg.c
+++ b/drivers/clk/imx/clk-imx8qxp-lpcg.c
@@ -370,7 +370,7 @@ static struct platform_driver imx8qxp_lpcg_clk_driver = {
.probe = imx8qxp_lpcg_clk_probe,
};

-builtin_platform_driver(imx8qxp_lpcg_clk_driver);
+module_platform_driver(imx8qxp_lpcg_clk_driver);

MODULE_AUTHOR("Aisheng Dong <[email protected]>");
MODULE_DESCRIPTION("NXP i.MX8QXP LPCG clock driver");
diff --git a/drivers/clk/imx/clk-imx8qxp.c b/drivers/clk/imx/clk-imx8qxp.c
index c53a688d8ccc..40a2efb1329b 100644
--- a/drivers/clk/imx/clk-imx8qxp.c
+++ b/drivers/clk/imx/clk-imx8qxp.c
@@ -308,7 +308,7 @@ static struct platform_driver imx8qxp_clk_driver = {
},
.probe = imx8qxp_clk_probe,
};
-builtin_platform_driver(imx8qxp_clk_driver);
+module_platform_driver(imx8qxp_clk_driver);

MODULE_AUTHOR("Aisheng Dong <[email protected]>");
MODULE_DESCRIPTION("NXP i.MX8QXP clock driver");
--
2.18.0


2021-09-03 19:17:49

by Stephen Boyd

[permalink] [raw]
Subject: Re: [PATCH] clk: imx: use module_platform_driver

Quoting Miles Chen (2021-09-02 01:02:11)
> Replace builtin_platform_driver_probe with module_platform_driver_probe
> because that CONFIG_CLK_IMX8QXP can be set to =m (kernel module).
>
> Cc: Stephen Boyd <[email protected]>
> Signed-off-by: Miles Chen <[email protected]>
> ---

Should it have a fixes tag?

2021-09-04 15:19:47

by Miles Chen

[permalink] [raw]
Subject: Re: [PATCH] clk: imx: use module_platform_driver

On Fri, 2021-09-03 at 11:33 -0700, Stephen Boyd wrote:
> Quoting Miles Chen (2021-09-02 01:02:11)
> > Replace builtin_platform_driver_probe with
> > module_platform_driver_probe
> > because that CONFIG_CLK_IMX8QXP can be set to =m (kernel module).
> >
> > Cc: Stephen Boyd <[email protected]>
> > Signed-off-by: Miles Chen <[email protected]>
> > ---
>
> Should it have a fixes tag?

ok, I will add a fixes tags in the next patch.