2021-09-03 06:43:45

by Yang Li

Subject: [PATCH -next] ethtool: Fix an error code in cxgb2.c

When adapter->registered_device_map is NULL, the value of err is
uncertain, we set err to -EINVAL to avoid ambiguity.

Clean up smatch warning:
drivers/net/ethernet/chelsio/cxgb/cxgb2.c:1114 init_one() warn: missing
error code 'err'

Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Yang Li <[email protected]>
---
drivers/net/ethernet/chelsio/cxgb/cxgb2.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/chelsio/cxgb/cxgb2.c b/drivers/net/ethernet/chelsio/cxgb/cxgb2.c
index 73c0161..d246eee 100644
--- a/drivers/net/ethernet/chelsio/cxgb/cxgb2.c
+++ b/drivers/net/ethernet/chelsio/cxgb/cxgb2.c
@@ -1111,6 +1111,7 @@ static int init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
if (!adapter->registered_device_map) {
pr_err("%s: could not register any net devices\n",
pci_name(pdev));
+ err = -EINVAL;
goto out_release_adapter_res;
}

--
1.8.3.1

2021-09-04 10:02:07

by patchwork-bot+netdevbpf

Subject: Re: [PATCH -next] ethtool: Fix an error code in cxgb2.c

Hello:

This patch was applied to netdev/net.git (refs/heads/master):

On Fri, 3 Sep 2021 14:42:33 +0800 you wrote:
> When adapter->registered_device_map is NULL, the value of err is
> uncertain, we set err to -EINVAL to avoid ambiguity.
>
> Clean up smatch warning:
> drivers/net/ethernet/chelsio/cxgb/cxgb2.c:1114 init_one() warn: missing
> error code 'err'
>
> [...]

Here is the summary with links:
- [-next] ethtool: Fix an error code in cxgb2.c
https://git.kernel.org/netdev/net/c/7db8263a1215

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html