Add support to enable/disable output for Qualcomm SPMI GPIO.
Subbaraman Narayanamurthy (2):
dt-bindings: pinctrl: qcom-pmic-gpio: Add output-{enable,disable}
properties
pinctrl: qcom: spmi-gpio: add support to enable/disable output
Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml | 2 ++
drivers/pinctrl/qcom/pinctrl-spmi-gpio.c | 8 +++++++-
2 files changed, 9 insertions(+), 1 deletion(-)
--
2.7.4
Add support for the pinconf DT property output-enable, output-disable
so that output can be enabled/disabled.
Signed-off-by: Subbaraman Narayanamurthy <[email protected]>
---
Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml
index 9bd01db..fa7c319 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml
@@ -170,6 +170,8 @@ $defs:
input-enable: true
output-high: true
output-low: true
+ output-enable: true
+ output-disable: true
power-source: true
qcom,drive-strength:
--
2.7.4
Currently, if the GPIO is configured as output in the bootloader
and user changes the mode to input in HLOS, it would end up
getting configured as input/output. Functionally, this is fine;
however, there may be some requirements where the output needs
to be disabled so that it can be used only for input.
Add support to enable/disable output mode through "output-enable"
or "output-disable" pinctrl properties.
Signed-off-by: Subbaraman Narayanamurthy <[email protected]>
---
drivers/pinctrl/qcom/pinctrl-spmi-gpio.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
index 98bf0e2..39a18aa 100644
--- a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
+++ b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
@@ -1,6 +1,6 @@
// SPDX-License-Identifier: GPL-2.0-only
/*
- * Copyright (c) 2012-2014, The Linux Foundation. All rights reserved.
+ * Copyright (c) 2012-2014, 2021, The Linux Foundation. All rights reserved.
*/
#include <linux/gpio/driver.h>
@@ -424,6 +424,9 @@ static int pmic_gpio_config_get(struct pinctrl_dev *pctldev,
return -EINVAL;
arg = 1;
break;
+ case PIN_CONFIG_OUTPUT_ENABLE:
+ arg = pad->output_enabled;
+ break;
case PIN_CONFIG_OUTPUT:
arg = pad->out_value;
break;
@@ -503,6 +506,9 @@ static int pmic_gpio_config_set(struct pinctrl_dev *pctldev, unsigned int pin,
case PIN_CONFIG_INPUT_ENABLE:
pad->input_enabled = arg ? true : false;
break;
+ case PIN_CONFIG_OUTPUT_ENABLE:
+ pad->output_enabled = arg ? true : false;
+ break;
case PIN_CONFIG_OUTPUT:
pad->output_enabled = true;
pad->out_value = arg;
--
2.7.4
On Mon, 13 Sep 2021 19:57:25 -0700, Subbaraman Narayanamurthy wrote:
> Add support for the pinconf DT property output-enable, output-disable
> so that output can be enabled/disabled.
>
> Signed-off-by: Subbaraman Narayanamurthy <[email protected]>
> ---
> Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
Acked-by: Rob Herring <[email protected]>
On Mon 13 Sep 21:57 CDT 2021, Subbaraman Narayanamurthy wrote:
> Currently, if the GPIO is configured as output in the bootloader
> and user changes the mode to input in HLOS, it would end up
> getting configured as input/output. Functionally, this is fine;
> however, there may be some requirements where the output needs
> to be disabled so that it can be used only for input.
>
> Add support to enable/disable output mode through "output-enable"
> or "output-disable" pinctrl properties.
>
> Signed-off-by: Subbaraman Narayanamurthy <[email protected]>
Reviewed-by: Bjorn Andersson <[email protected]>
Regards,
Bjorn
> ---
> drivers/pinctrl/qcom/pinctrl-spmi-gpio.c | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
> index 98bf0e2..39a18aa 100644
> --- a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
> +++ b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
> @@ -1,6 +1,6 @@
> // SPDX-License-Identifier: GPL-2.0-only
> /*
> - * Copyright (c) 2012-2014, The Linux Foundation. All rights reserved.
> + * Copyright (c) 2012-2014, 2021, The Linux Foundation. All rights reserved.
> */
>
> #include <linux/gpio/driver.h>
> @@ -424,6 +424,9 @@ static int pmic_gpio_config_get(struct pinctrl_dev *pctldev,
> return -EINVAL;
> arg = 1;
> break;
> + case PIN_CONFIG_OUTPUT_ENABLE:
> + arg = pad->output_enabled;
> + break;
> case PIN_CONFIG_OUTPUT:
> arg = pad->out_value;
> break;
> @@ -503,6 +506,9 @@ static int pmic_gpio_config_set(struct pinctrl_dev *pctldev, unsigned int pin,
> case PIN_CONFIG_INPUT_ENABLE:
> pad->input_enabled = arg ? true : false;
> break;
> + case PIN_CONFIG_OUTPUT_ENABLE:
> + pad->output_enabled = arg ? true : false;
> + break;
> case PIN_CONFIG_OUTPUT:
> pad->output_enabled = true;
> pad->out_value = arg;
> --
> 2.7.4
>
On Tue, Sep 14, 2021 at 4:57 AM Subbaraman Narayanamurthy
<[email protected]> wrote:
> Add support for the pinconf DT property output-enable, output-disable
> so that output can be enabled/disabled.
>
> Signed-off-by: Subbaraman Narayanamurthy <[email protected]>
Both patches applied! Thanks!
Yours,
Linus Walleij