2021-09-01 23:50:38

by Miles Chen

Subject: [PATCH v3 0/4] clk: mediatek: modularize COMMON_CLK_MT6779

This patch set makes COMMON_CLK_MEDIATEK and COMMON_CLK_MT6779*
be able to built as kernel modules. Necessary symbols are exported
in this patch.

In previous discussion [1], Stephen commented that there must
be a user before exporting a symbol:

"
Is the mediatek driver compilable as a module? Last time I checked it
wasn't a module. I want an upstream modular driver that uses the symbol.
Otherwise we're exporting symbols when it doesn't need to be.
"

[1] https://lore.kernel.org/patchwork/patch/1278089/

---

Change since v1:
use module_platform_driver() instead of builtin_platform_driver()

Change since v2:
squash "bool to tristate" change


Miles Chen (3):
clk: composite: export clk_register_composite
clk: mediatek: support COMMON_CLK_MEDIATEK module build
clk: mediatek: support COMMON_CLK_MT6779 module build

drivers/clk/clk-composite.c | 1 +
drivers/clk/mediatek/Kconfig | 20 ++++++++++----------
drivers/clk/mediatek/clk-apmixed.c | 3 +++
drivers/clk/mediatek/clk-cpumux.c | 3 +++
drivers/clk/mediatek/clk-gate.c | 8 ++++++++
drivers/clk/mediatek/clk-mt6779-aud.c | 4 +++-
drivers/clk/mediatek/clk-mt6779-cam.c | 4 +++-
drivers/clk/mediatek/clk-mt6779-img.c | 4 +++-
drivers/clk/mediatek/clk-mt6779-ipe.c | 4 +++-
drivers/clk/mediatek/clk-mt6779-mfg.c | 4 +++-
drivers/clk/mediatek/clk-mt6779-mm.c | 4 +++-
drivers/clk/mediatek/clk-mt6779-vdec.c | 4 +++-
drivers/clk/mediatek/clk-mt6779-venc.c | 4 +++-
drivers/clk/mediatek/clk-mt6779.c | 2 ++
drivers/clk/mediatek/clk-mtk.c | 8 ++++++++
drivers/clk/mediatek/clk-mux.c | 4 ++++
drivers/clk/mediatek/clk-pll.c | 4 ++++
drivers/clk/mediatek/reset.c | 2 ++
18 files changed, 69 insertions(+), 18 deletions(-)

--
2.18.0

2021-09-15 01:24:38

by Stephen Boyd

Subject: Re: [PATCH v3 0/4] clk: mediatek: modularize COMMON_CLK_MT6779

Quoting Miles Chen (2021-09-01 15:25:23)
> This patch set makes COMMON_CLK_MEDIATEK and COMMON_CLK_MT6779*
> be able to built as kernel modules. Necessary symbols are exported
> in this patch.
>

The subject says 4 patches but there's really only three.

2021-09-15 01:51:46

by Miles Chen

Subject: Re: [PATCH v3 0/4] clk: mediatek: modularize COMMON_CLK_MT6779

On Tue, 2021-09-14 at 18:23 -0700, Stephen Boyd wrote:
> Quoting Miles Chen (2021-09-01 15:25:23)
> > This patch set makes COMMON_CLK_MEDIATEK and COMMON_CLK_MT6779*
> > be able to built as kernel modules. Necessary symbols are exported
> > in this patch.
> >
>
> The subject says 4 patches but there's really only three.

yes, there should be only 3 patches. sorry for the incorrect "0/4"
cover letter.

Miles