2021-09-15 12:20:53

by Nishanth Menon

Subject: [PATCH 1/3] dt-bindings: arm: ti: Add missing compatibles for j721e/j7200 evms

Add compatibles for j721e and j7200 evms to allow for newer platforms
to distinguish themselves.

Signed-off-by: Nishanth Menon <[email protected]>
---
Documentation/devicetree/bindings/arm/ti/k3.yaml | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/Documentation/devicetree/bindings/arm/ti/k3.yaml b/Documentation/devicetree/bindings/arm/ti/k3.yaml
index c5aa362e4026..29ca364e8a76 100644
--- a/Documentation/devicetree/bindings/arm/ti/k3.yaml
+++ b/Documentation/devicetree/bindings/arm/ti/k3.yaml
@@ -29,10 +29,14 @@ properties:

- description: K3 J721E SoC
items:
+ - enum:
+ - ti,j721e-evm
- const: ti,j721e

- description: K3 J7200 SoC
items:
+ - enum:
+ - ti,j7200-evm
- const: ti,j7200

- description: K3 AM642 SoC
--
2.32.0

2021-09-16 12:23:04

by Rob Herring (Arm)

Subject: Re: [PATCH 1/3] dt-bindings: arm: ti: Add missing compatibles for j721e/j7200 evms

On Wed, 15 Sep 2021 07:19:35 -0500, Nishanth Menon wrote:
> Add compatibles for j721e and j7200 evms to allow for newer platforms
> to distinguish themselves.
>
> Signed-off-by: Nishanth Menon <[email protected]>
> ---
> Documentation/devicetree/bindings/arm/ti/k3.yaml | 4 ++++
> 1 file changed, 4 insertions(+)
>

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.example.dt.yaml: /: compatible: 'oneOf' conditional failed, one must be fixed:
['ti,j721e'] is too short
'ti,j721e' is not one of ['ti,am654-evm', 'siemens,iot2050-basic', 'siemens,iot2050-advanced']
'ti,j721e' is not one of ['ti,j721e-evm']
'ti,j721e' is not one of ['ti,j7200-evm']
'ti,j721e' is not one of ['ti,am642-evm', 'ti,am642-sk']
From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/ti/k3.yaml

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/patch/1528330

This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit.

2021-09-16 12:44:06

by Nishanth Menon

Subject: Re: [PATCH 1/3] dt-bindings: arm: ti: Add missing compatibles for j721e/j7200 evms

On 07:21-20210916, Rob Herring wrote:
> On Wed, 15 Sep 2021 07:19:35 -0500, Nishanth Menon wrote:
> > Add compatibles for j721e and j7200 evms to allow for newer platforms
> > to distinguish themselves.
> >
> > Signed-off-by: Nishanth Menon <[email protected]>
> > ---
> > Documentation/devicetree/bindings/arm/ti/k3.yaml | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
>
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.example.dt.yaml: /: compatible: 'oneOf' conditional failed, one must be fixed:
> ['ti,j721e'] is too short
> 'ti,j721e' is not one of ['ti,am654-evm', 'siemens,iot2050-basic', 'siemens,iot2050-advanced']
> 'ti,j721e' is not one of ['ti,j721e-evm']
> 'ti,j721e' is not one of ['ti,j7200-evm']
> 'ti,j721e' is not one of ['ti,am642-evm', 'ti,am642-sk']
> From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/ti/k3.yaml
>


Aaargh, crap ->
https://lore.kernel.org/linux-devicetree/[email protected]/

needs to be resolved first.
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D