2021-09-21 13:37:46

by Fabrice Gasnier

[permalink] [raw]
Subject: [PATCH] ARM: dts: stm32: fix STUSB1600 Type-C irq level on stm32mp15xx-dkx

STUSB1600 IRQ (Alert pin) is active low (open drain). Interrupts may get
lost currently, so fix the IRQ type.

Fixes: 83686162c0eb ("ARM: dts: stm32: add STUSB1600 Type-C using I2C4 on stm32mp15xx-dkx")

Signed-off-by: Fabrice Gasnier <[email protected]>
---
arch/arm/boot/dts/stm32mp15xx-dkx.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/stm32mp15xx-dkx.dtsi b/arch/arm/boot/dts/stm32mp15xx-dkx.dtsi
index 9a95489..878ea36 100644
--- a/arch/arm/boot/dts/stm32mp15xx-dkx.dtsi
+++ b/arch/arm/boot/dts/stm32mp15xx-dkx.dtsi
@@ -260,7 +260,7 @@
stusb1600@28 {
compatible = "st,stusb1600";
reg = <0x28>;
- interrupts = <11 IRQ_TYPE_EDGE_FALLING>;
+ interrupts = <11 IRQ_TYPE_LEVEL_LOW>;
interrupt-parent = <&gpioi>;
pinctrl-names = "default";
pinctrl-0 = <&stusb1600_pins_a>;
--
2.7.4


2021-10-16 03:20:54

by Alexandre TORGUE

[permalink] [raw]
Subject: Re: [PATCH] ARM: dts: stm32: fix STUSB1600 Type-C irq level on stm32mp15xx-dkx

On 9/21/21 3:34 PM, Fabrice Gasnier wrote:
> STUSB1600 IRQ (Alert pin) is active low (open drain). Interrupts may get
> lost currently, so fix the IRQ type.
>
> Fixes: 83686162c0eb ("ARM: dts: stm32: add STUSB1600 Type-C using I2C4 on stm32mp15xx-dkx")
>
> Signed-off-by: Fabrice Gasnier <[email protected]>
> ---
> arch/arm/boot/dts/stm32mp15xx-dkx.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/stm32mp15xx-dkx.dtsi b/arch/arm/boot/dts/stm32mp15xx-dkx.dtsi
> index 9a95489..878ea36 100644
> --- a/arch/arm/boot/dts/stm32mp15xx-dkx.dtsi
> +++ b/arch/arm/boot/dts/stm32mp15xx-dkx.dtsi
> @@ -260,7 +260,7 @@
> stusb1600@28 {
> compatible = "st,stusb1600";
> reg = <0x28>;
> - interrupts = <11 IRQ_TYPE_EDGE_FALLING>;
> + interrupts = <11 IRQ_TYPE_LEVEL_LOW>;
> interrupt-parent = <&gpioi>;
> pinctrl-names = "default";
> pinctrl-0 = <&stusb1600_pins_a>;
>

Applied on stm32-next.

Thanks
Alex