2021-09-23 09:35:43

by Rajendra Nayak

Subject: [PATCH v2] pinctrl: qcom: sc7280: Add PM suspend callbacks

Use PM suspend callbacks from msm core, without this the hog_sleep
pins don't change state in suspend.

Signed-off-by: Rajendra Nayak <[email protected]>
---
v2: removed some stale diffstat

drivers/pinctrl/qcom/pinctrl-sc7280.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/pinctrl/qcom/pinctrl-sc7280.c b/drivers/pinctrl/qcom/pinctrl-sc7280.c
index 607d459..1cbf2cc 100644
--- a/drivers/pinctrl/qcom/pinctrl-sc7280.c
+++ b/drivers/pinctrl/qcom/pinctrl-sc7280.c
@@ -1498,6 +1498,7 @@ static const struct of_device_id sc7280_pinctrl_of_match[] = {
static struct platform_driver sc7280_pinctrl_driver = {
.driver = {
.name = "sc7280-pinctrl",
+ .pm = &msm_pinctrl_dev_pm_ops,
.of_match_table = sc7280_pinctrl_of_match,
},
.probe = sc7280_pinctrl_probe,
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation

2021-09-23 17:25:39

by Bjorn Andersson

Subject: Re: [PATCH v2] pinctrl: qcom: sc7280: Add PM suspend callbacks

On Thu 23 Sep 04:31 CDT 2021, Rajendra Nayak wrote:

> Use PM suspend callbacks from msm core, without this the hog_sleep
> pins don't change state in suspend.
>
> Signed-off-by: Rajendra Nayak <[email protected]>

Reviewed-by: Bjorn Andersson <[email protected]>

> ---
> v2: removed some stale diffstat
>
> drivers/pinctrl/qcom/pinctrl-sc7280.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pinctrl/qcom/pinctrl-sc7280.c b/drivers/pinctrl/qcom/pinctrl-sc7280.c
> index 607d459..1cbf2cc 100644
> --- a/drivers/pinctrl/qcom/pinctrl-sc7280.c
> +++ b/drivers/pinctrl/qcom/pinctrl-sc7280.c
> @@ -1498,6 +1498,7 @@ static const struct of_device_id sc7280_pinctrl_of_match[] = {
> static struct platform_driver sc7280_pinctrl_driver = {
> .driver = {
> .name = "sc7280-pinctrl",
> + .pm = &msm_pinctrl_dev_pm_ops,
> .of_match_table = sc7280_pinctrl_of_match,
> },
> .probe = sc7280_pinctrl_probe,
> --
> QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
> of Code Aurora Forum, hosted by The Linux Foundation
>

2021-09-23 21:14:19

by Linus Walleij

Subject: Re: [PATCH v2] pinctrl: qcom: sc7280: Add PM suspend callbacks

On Thu, Sep 23, 2021 at 11:31 AM Rajendra Nayak <[email protected]> wrote:

> Use PM suspend callbacks from msm core, without this the hog_sleep
> pins don't change state in suspend.
>
> Signed-off-by: Rajendra Nayak <[email protected]>
> ---
> v2: removed some stale diffstat

Patch applied for fixes!

Yours,
Linus Walleij