2021-09-25 12:51:18

by Cai,Huoqing

Subject: [PATCH] net: cisco: Fix a function name in comments

Use dma_alloc_coherent() instead of pci_alloc_consistent(),
because only dma_alloc_coherent() is called here.

Signed-off-by: Cai Huoqing <[email protected]>
---
drivers/net/ethernet/cisco/enic/enic_ethtool.c | 4 ++--
drivers/net/ethernet/cisco/enic/enic_main.c | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/net/ethernet/cisco/enic/enic_ethtool.c b/drivers/net/ethernet/cisco/enic/enic_ethtool.c
index 12ffc14fbecd..6ded4d9fa32a 100644
--- a/drivers/net/ethernet/cisco/enic/enic_ethtool.c
+++ b/drivers/net/ethernet/cisco/enic/enic_ethtool.c
@@ -139,7 +139,7 @@ static void enic_get_drvinfo(struct net_device *netdev,
int err;

err = enic_dev_fw_info(enic, &fw_info);
- /* return only when pci_zalloc_consistent fails in vnic_dev_fw_info
+ /* return only when dma_alloc_coherent fails in vnic_dev_fw_info
* For other failures, like devcmd failure, we return previously
* recorded info.
*/
@@ -270,7 +270,7 @@ static void enic_get_ethtool_stats(struct net_device *netdev,
int err;

err = enic_dev_stats_dump(enic, &vstats);
- /* return only when pci_zalloc_consistent fails in vnic_dev_stats_dump
+ /* return only when dma_alloc_coherent fails in vnic_dev_stats_dump
* For other failures, like devcmd failure, we return previously
* recorded stats.
*/
diff --git a/drivers/net/ethernet/cisco/enic/enic_main.c b/drivers/net/ethernet/cisco/enic/enic_main.c
index d0a8f7106958..13dbdd5d07b4 100644
--- a/drivers/net/ethernet/cisco/enic/enic_main.c
+++ b/drivers/net/ethernet/cisco/enic/enic_main.c
@@ -882,7 +882,7 @@ static void enic_get_stats(struct net_device *netdev,
int err;

err = enic_dev_stats_dump(enic, &stats);
- /* return only when pci_zalloc_consistent fails in vnic_dev_stats_dump
+ /* return only when dma_alloc_coherent fails in vnic_dev_stats_dump
* For other failures, like devcmd failure, we return previously
* recorded stats.
*/
--
2.25.1

2021-09-26 23:50:04

by Govindarajulu Varadarajan

Subject: Re: [PATCH] net: cisco: Fix a function name in comments

On Sat, Sep 25, 2021 at 5:46 AM Cai Huoqing <[email protected]> wrote:
>
> Use dma_alloc_coherent() instead of pci_alloc_consistent(),
> because only dma_alloc_coherent() is called here.
>
> Signed-off-by: Cai Huoqing <[email protected]>

Thanks.

Reviewed-by: Govindarajulu Varadarajan <[email protected]>

2021-09-27 12:33:10

by patchwork-bot+netdevbpf

Subject: Re: [PATCH] net: cisco: Fix a function name in comments

Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Sat, 25 Sep 2021 20:46:28 +0800 you wrote:
> Use dma_alloc_coherent() instead of pci_alloc_consistent(),
> because only dma_alloc_coherent() is called here.
>
> Signed-off-by: Cai Huoqing <[email protected]>
> ---
> drivers/net/ethernet/cisco/enic/enic_ethtool.c | 4 ++--
> drivers/net/ethernet/cisco/enic/enic_main.c | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)

Here is the summary with links:
- net: cisco: Fix a function name in comments
https://git.kernel.org/netdev/net-next/c/f947fcaffd6a

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html