2021-09-24 12:13:23

by Jiapeng Chong

Subject: [PATCH] scsi: ses: Fix unsigned comparison with less than zero

Fix the following coccicheck warning:

./drivers/scsi/ses.c:137:10-16: WARNING: Unsigned expression compared
with zero: result > 0.

Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Jiapeng Chong <[email protected]>
---
drivers/scsi/ses.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/ses.c b/drivers/scsi/ses.c
index 43e6822..0a1734f 100644
--- a/drivers/scsi/ses.c
+++ b/drivers/scsi/ses.c
@@ -118,7 +118,7 @@ static int ses_recv_diag(struct scsi_device *sdev, int page_code,
static int ses_send_diag(struct scsi_device *sdev, int page_code,
void *buf, int bufflen)
{
- u32 result;
+ int result;

unsigned char cmd[] = {
SEND_DIAGNOSTIC,
--
1.8.3.1

2021-09-29 04:24:52

by Martin K. Petersen

Subject: Re: [PATCH] scsi: ses: Fix unsigned comparison with less than zero

On Fri, 24 Sep 2021 17:51:53 +0800, Jiapeng Chong wrote:

> Fix the following coccicheck warning:
>
> ./drivers/scsi/ses.c:137:10-16: WARNING: Unsigned expression compared
> with zero: result > 0.
>
>

Applied to 5.15/scsi-fixes, thanks!

[1/1] scsi: ses: Fix unsigned comparison with less than zero
https://git.kernel.org/mkp/scsi/c/dd689ed5aa90

--
Martin K. Petersen Oracle Linux Engineering