Subject: Re: [PATCH] video/fbdev/stifb: Delete an error message for a failed memory allocation in stifb_init_fb()

On Friday, November 24, 2017 10:30:34 PM Rolf Eike Beer wrote:
> Markus Elfring wrote:
> > From: Markus Elfring <[email protected]>
> > Date: Fri, 24 Nov 2017 22:22:06 +0100
> >
> > Omit an extra message for a memory allocation failure in this function.
> >
> > This issue was detected by using the Coccinelle software.
> >
> > Signed-off-by: Markus Elfring <[email protected]>
> > ---
> > drivers/video/fbdev/stifb.c | 4 +---
> > 1 file changed, 1 insertion(+), 3 deletions(-)
> >
> > diff --git a/drivers/video/fbdev/stifb.c b/drivers/video/fbdev/stifb.c
> > index 6ded5c198998..fe217a2f7d21 100644
> > --- a/drivers/video/fbdev/stifb.c
> > +++ b/drivers/video/fbdev/stifb.c
> > @@ -1126,10 +1126,8 @@ static int __init stifb_init_fb(struct sti_struct
> > *sti, int bpp_pref) int bpp, xres, yres;
> >
> > fb = kzalloc(sizeof(*fb), GFP_ATOMIC);
> > - if (!fb) {
> > - printk(KERN_ERR "stifb: Could not allocate stifb structure\n");
> > + if (!fb)
> > return -ENODEV;
> > - }
> >
> > info = &fb->info;
>
> This should be -ENOMEM.

Markus, please fix this issue first (before doing cleanups).

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics


2018-01-07 11:56:01

by SF Markus Elfring

[permalink] [raw]
Subject: [PATCH v2 0/2] video/fbdev/stifb: Adjustments for stifb_init_fb()

From: Markus Elfring <[email protected]>
Date: Sun, 7 Jan 2018 12:45:54 +0100

Two update suggestions were taken into account.

Markus Elfring (2):
Return -ENOMEM after a failed kzalloc()
Delete an error message for a failed memory allocation

drivers/video/fbdev/stifb.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)

--
2.15.1

2018-01-07 11:57:25

by SF Markus Elfring

[permalink] [raw]
Subject: [PATCH v2 1/2] video/fbdev/stifb: Return -ENOMEM after a failed kzalloc() in stifb_init_fb()

From: Markus Elfring <[email protected]>
Date: Sun, 7 Jan 2018 11:33:59 +0100

Replace an error code for the indication of a memory allocation failure
in this function.

Fixes: 1da177e4c3f41524e886b7f1b8a0c1fc7321cac ("Linux-2.6.12-rc2: Initial git repository build")
Suggested-by: Rolf Eike Beer <[email protected]>
Signed-off-by: Markus Elfring <[email protected]>
---
drivers/video/fbdev/stifb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/video/fbdev/stifb.c b/drivers/video/fbdev/stifb.c
index 6ded5c198998..511a594889af 100644
--- a/drivers/video/fbdev/stifb.c
+++ b/drivers/video/fbdev/stifb.c
@@ -1128,7 +1128,7 @@ static int __init stifb_init_fb(struct sti_struct *sti, int bpp_pref)
fb = kzalloc(sizeof(*fb), GFP_ATOMIC);
if (!fb) {
printk(KERN_ERR "stifb: Could not allocate stifb structure\n");
- return -ENODEV;
+ return -ENOMEM;
}

info = &fb->info;
--
2.15.1

2018-01-07 11:59:37

by SF Markus Elfring

[permalink] [raw]
Subject: [PATCH v2 2/2] video/fbdev/stifb: Delete an error message for a failed memory allocation in stifb_init_fb()

From: Markus Elfring <[email protected]>
Date: Sun, 7 Jan 2018 12:34:22 +0100

Omit an extra message for a memory allocation failure in this function.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <[email protected]>
---

v2:
This update suggestion was rebased on source files from the software
"Linux next-20180105" together with a change for an error code.

drivers/video/fbdev/stifb.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/video/fbdev/stifb.c b/drivers/video/fbdev/stifb.c
index 511a594889af..dec8efb4f256 100644
--- a/drivers/video/fbdev/stifb.c
+++ b/drivers/video/fbdev/stifb.c
@@ -1126,10 +1126,8 @@ static int __init stifb_init_fb(struct sti_struct *sti, int bpp_pref)
int bpp, xres, yres;

fb = kzalloc(sizeof(*fb), GFP_ATOMIC);
- if (!fb) {
- printk(KERN_ERR "stifb: Could not allocate stifb structure\n");
+ if (!fb)
return -ENOMEM;
- }

info = &fb->info;

--
2.15.1

Subject: Re: [PATCH v2 1/2] video/fbdev/stifb: Return -ENOMEM after a failed kzalloc() in stifb_init_fb()

On Sunday, January 07, 2018 12:56:45 PM SF Markus Elfring wrote:
> From: Markus Elfring <[email protected]>
> Date: Sun, 7 Jan 2018 11:33:59 +0100
>
> Replace an error code for the indication of a memory allocation failure
> in this function.
>
> Fixes: 1da177e4c3f41524e886b7f1b8a0c1fc7321cac ("Linux-2.6.12-rc2: Initial git repository build")
> Suggested-by: Rolf Eike Beer <[email protected]>
> Signed-off-by: Markus Elfring <[email protected]>

Patch queued for 4.17, thanks.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics


Subject: Re: [PATCH v2 2/2] video/fbdev/stifb: Delete an error message for a failed memory allocation in stifb_init_fb()

On Sunday, January 07, 2018 12:58:47 PM SF Markus Elfring wrote:
> From: Markus Elfring <[email protected]>
> Date: Sun, 7 Jan 2018 12:34:22 +0100
>
> Omit an extra message for a memory allocation failure in this function.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <[email protected]>

Patch queued for 4.17, thanks.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics