2021-10-19 10:52:07

by Satya Priya

Subject: [PATCH V2 0/3] Add PM8350C PMIC PWM support for backlight

This series depends on [1], which adds driver for Qualcomm LPG.

[1] https://patchwork.kernel.org/project/linux-arm-msm/list/?series=560587&state=%2A&archive=both

satya priya (3):
dt-bindings: leds: Add pm8350c pmic support
leds: Add pm8350c support to Qualcomm LPG driver
arm64: dts: qcom: pm8350c: Add pwm support

Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml | 1 +
arch/arm64/boot/dts/qcom/pm8350c.dtsi | 6 ++++++
drivers/leds/rgb/leds-qcom-lpg.c | 10 ++++++++++
3 files changed, 17 insertions(+)

--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation

2021-10-19 10:52:36

by Satya Priya

Subject: [PATCH V2 1/3] dt-bindings: leds: Add pm8350c pmic support

From: satya priya <[email protected]>

Add pm8350c pmic pwm support.

Signed-off-by: satya priya <[email protected]>
Reviewed-by: Matthias Kaehlcke <[email protected]>
Reviewed-by: Stephen Boyd <[email protected]>
Acked-by: Rob Herring <[email protected]>
---
Changes in V2:
- No changes.

Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml | 1 +
1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml b/Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml
index 336bd8e..409a4c7 100644
--- a/Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml
+++ b/Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml
@@ -19,6 +19,7 @@ properties:
enum:
- qcom,pm8150b-lpg
- qcom,pm8150l-lpg
+ - qcom,pm8350c-pwm
- qcom,pm8916-pwm
- qcom,pm8941-lpg
- qcom,pm8994-lpg
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation

2021-10-19 10:52:52

by Satya Priya

Subject: [PATCH V2 2/3] leds: Add pm8350c support to Qualcomm LPG driver

From: satya priya <[email protected]>

Add pm8350c compatible and lpg_data to the driver.

Signed-off-by: satya priya <[email protected]>
Reviewed-by: Matthias Kaehlcke <[email protected]>
---
Changes in V2:
- Added const for lpg_channel_data[] struct.

drivers/leds/rgb/leds-qcom-lpg.c | 10 ++++++++++
1 file changed, 10 insertions(+)

diff --git a/drivers/leds/rgb/leds-qcom-lpg.c b/drivers/leds/rgb/leds-qcom-lpg.c
index 45ef4ec..99235af 100644
--- a/drivers/leds/rgb/leds-qcom-lpg.c
+++ b/drivers/leds/rgb/leds-qcom-lpg.c
@@ -1275,9 +1275,19 @@ static const struct lpg_data pm8150l_lpg_data = {
},
};

+static const struct lpg_data pm8350c_pwm_data = {
+ .pwm_9bit_mask = BIT(2),
+
+ .num_channels = 1,
+ .channels = (const struct lpg_channel_data[]) {
+ { .base = 0xeb00 },
+ },
+};
+
static const struct of_device_id lpg_of_table[] = {
{ .compatible = "qcom,pm8150b-lpg", .data = &pm8150b_lpg_data },
{ .compatible = "qcom,pm8150l-lpg", .data = &pm8150l_lpg_data },
+ { .compatible = "qcom,pm8350c-pwm", .data = &pm8350c_pwm_data },
{ .compatible = "qcom,pm8916-pwm", .data = &pm8916_pwm_data },
{ .compatible = "qcom,pm8941-lpg", .data = &pm8941_lpg_data },
{ .compatible = "qcom,pm8994-lpg", .data = &pm8994_lpg_data },
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation

2021-10-22 17:22:13

by Bjorn Andersson

Subject: Re: [PATCH V2 2/3] leds: Add pm8350c support to Qualcomm LPG driver

On Tue 19 Oct 03:48 PDT 2021, Satya Priya wrote:

> From: satya priya <[email protected]>
>
> Add pm8350c compatible and lpg_data to the driver.
>
> Signed-off-by: satya priya <[email protected]>
> Reviewed-by: Matthias Kaehlcke <[email protected]>
> ---
> Changes in V2:
> - Added const for lpg_channel_data[] struct.
>
> drivers/leds/rgb/leds-qcom-lpg.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/drivers/leds/rgb/leds-qcom-lpg.c b/drivers/leds/rgb/leds-qcom-lpg.c
> index 45ef4ec..99235af 100644
> --- a/drivers/leds/rgb/leds-qcom-lpg.c
> +++ b/drivers/leds/rgb/leds-qcom-lpg.c
> @@ -1275,9 +1275,19 @@ static const struct lpg_data pm8150l_lpg_data = {
> },
> };
>
> +static const struct lpg_data pm8350c_pwm_data = {
> + .pwm_9bit_mask = BIT(2),
> +
> + .num_channels = 1,

No, this should be 4. The fact that you only care about the first
channel in your product should be reflected in the dts, not in the
driver.

Thanks,
Bjorn

> + .channels = (const struct lpg_channel_data[]) {
> + { .base = 0xeb00 },
> + },
> +};
> +
> static const struct of_device_id lpg_of_table[] = {
> { .compatible = "qcom,pm8150b-lpg", .data = &pm8150b_lpg_data },
> { .compatible = "qcom,pm8150l-lpg", .data = &pm8150l_lpg_data },
> + { .compatible = "qcom,pm8350c-pwm", .data = &pm8350c_pwm_data },
> { .compatible = "qcom,pm8916-pwm", .data = &pm8916_pwm_data },
> { .compatible = "qcom,pm8941-lpg", .data = &pm8941_lpg_data },
> { .compatible = "qcom,pm8994-lpg", .data = &pm8994_lpg_data },
> --
> QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
> of Code Aurora Forum, hosted by The Linux Foundation
>