2021-08-28 18:02:41

by Kees Cook

Subject: [PATCH] clocksource/drivers/timer-ti-dm: Select TIMER_OF

When building OMAP_DM_TIMER without TIMER_OF, there are orphan sections
due to the use of TIMER_OF_DELCARE() without CONFIG_TIMER_OF. Select
CONFIG_TIMER_OF when enaling OMAP_DM_TIMER:

arm-linux-gnueabi-ld: warning: orphan section `__timer_of_table' from `drivers/clocksource/timer-ti-dm-systimer.o' being placed in section `__timer_of_table'

Reported-by: kernel test robot <[email protected]>
Link: https://lore.kernel.org/lkml/[email protected]/
Cc: Tony Lindgren <[email protected]>
Cc: Daniel Lezcano <[email protected]>
Cc: Keerthy <[email protected]>
Cc: Sebastian Reichel <[email protected]>
Cc: Ladislav Michl <[email protected]>
Cc: Grygorii Strashko <[email protected]>
Cc: [email protected]
Fixes: 52762fbd1c47 ("clocksource/drivers/timer-ti-dm: Add clockevent and clocksource support")
Signed-off-by: Kees Cook <[email protected]>
---
drivers/clocksource/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
index 0f5e3983951a..08f8cb944a2a 100644
--- a/drivers/clocksource/Kconfig
+++ b/drivers/clocksource/Kconfig
@@ -24,6 +24,7 @@ config I8253_LOCK

config OMAP_DM_TIMER
bool
+ select TIMER_OF

config CLKBLD_I8253
def_bool y if CLKSRC_I8253 || CLKEVT_I8253 || I8253_LOCK
--
2.30.2

2021-09-30 14:23:09

by Tony Lindgren

Subject: Re: [PATCH] clocksource/drivers/timer-ti-dm: Select TIMER_OF

* Kees Cook <[email protected]> [210828 17:58]:
> When building OMAP_DM_TIMER without TIMER_OF, there are orphan sections
> due to the use of TIMER_OF_DELCARE() without CONFIG_TIMER_OF. Select
> CONFIG_TIMER_OF when enaling OMAP_DM_TIMER:
>
> arm-linux-gnueabi-ld: warning: orphan section `__timer_of_table' from `drivers/clocksource/timer-ti-dm-systimer.o' being placed in section `__timer_of_table'
>
> Reported-by: kernel test robot <[email protected]>
> Link: https://lore.kernel.org/lkml/[email protected]/
> Cc: Tony Lindgren <[email protected]>
> Cc: Daniel Lezcano <[email protected]>
> Cc: Keerthy <[email protected]>
> Cc: Sebastian Reichel <[email protected]>
> Cc: Ladislav Michl <[email protected]>
> Cc: Grygorii Strashko <[email protected]>
> Cc: [email protected]
> Fixes: 52762fbd1c47 ("clocksource/drivers/timer-ti-dm: Add clockevent and clocksource support")
> Signed-off-by: Kees Cook <[email protected]>

Sorry for the delay, I just noticed I never replied earlier:

Acked-by: Tony Lindgren <[email protected]>

> ---
> drivers/clocksource/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
> index 0f5e3983951a..08f8cb944a2a 100644
> --- a/drivers/clocksource/Kconfig
> +++ b/drivers/clocksource/Kconfig
> @@ -24,6 +24,7 @@ config I8253_LOCK
>
> config OMAP_DM_TIMER
> bool
> + select TIMER_OF
>
> config CLKBLD_I8253
> def_bool y if CLKSRC_I8253 || CLKEVT_I8253 || I8253_LOCK
> --
> 2.30.2
>

2021-10-24 15:42:33

by tip-bot2 for Alexey Makhalov

Subject: [tip: timers/core] clocksource/drivers/timer-ti-dm: Select TIMER_OF

The following commit has been merged into the timers/core branch of tip:

Commit-ID: eda9a4f7af6ee47e9e131f20e4f8a41a97379293
Gitweb: https://git.kernel.org/tip/eda9a4f7af6ee47e9e131f20e4f8a41a97379293
Author: Kees Cook <[email protected]>
AuthorDate: Sat, 28 Aug 2021 10:57:47 -07:00
Committer: Daniel Lezcano <[email protected]>
CommitterDate: Thu, 21 Oct 2021 14:18:53 +02:00

clocksource/drivers/timer-ti-dm: Select TIMER_OF

When building OMAP_DM_TIMER without TIMER_OF, there are orphan sections
due to the use of TIMER_OF_DELCARE() without CONFIG_TIMER_OF. Select
CONFIG_TIMER_OF when enaling OMAP_DM_TIMER:

arm-linux-gnueabi-ld: warning: orphan section `__timer_of_table' from `drivers/clocksource/timer-ti-dm-systimer.o' being placed in section `__timer_of_table'

Reported-by: kernel test robot <[email protected]>
Link: https://lore.kernel.org/lkml/[email protected]/
Cc: Tony Lindgren <[email protected]>
Cc: Daniel Lezcano <[email protected]>
Cc: Keerthy <[email protected]>
Cc: Sebastian Reichel <[email protected]>
Cc: Ladislav Michl <[email protected]>
Cc: Grygorii Strashko <[email protected]>
Cc: [email protected]
Fixes: 52762fbd1c47 ("clocksource/drivers/timer-ti-dm: Add clockevent and clocksource support")
Signed-off-by: Kees Cook <[email protected]>
Acked-by: Tony Lindgren <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Daniel Lezcano <[email protected]>
---
drivers/clocksource/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
index ac56b56..e71ac54 100644
--- a/drivers/clocksource/Kconfig
+++ b/drivers/clocksource/Kconfig
@@ -24,6 +24,7 @@ config I8253_LOCK

config OMAP_DM_TIMER
bool
+ select TIMER_OF

config CLKBLD_I8253
def_bool y if CLKSRC_I8253 || CLKEVT_I8253 || I8253_LOCK