2021-10-25 14:37:47

by Fabrice Gasnier

Subject: [PATCH] phy: stm32: adopt dev_err_probe for regulators

Change stm32-usbphyc driver to use dev_err_probe(), to benefit of
devices_deferred debugfs in case of probe deferral.

Signed-off-by: Fabrice Gasnier <[email protected]>
---
drivers/phy/st/phy-stm32-usbphyc.c | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/drivers/phy/st/phy-stm32-usbphyc.c b/drivers/phy/st/phy-stm32-usbphyc.c
index 7df6a63..115be0e 100644
--- a/drivers/phy/st/phy-stm32-usbphyc.c
+++ b/drivers/phy/st/phy-stm32-usbphyc.c
@@ -672,17 +672,15 @@ static int stm32_usbphyc_probe(struct platform_device *pdev)

usbphyc->vdda1v1 = devm_regulator_get(dev, "vdda1v1");
if (IS_ERR(usbphyc->vdda1v1)) {
- ret = PTR_ERR(usbphyc->vdda1v1);
- if (ret != -EPROBE_DEFER)
- dev_err(dev, "failed to get vdda1v1 supply: %d\n", ret);
+ ret = dev_err_probe(dev, PTR_ERR(usbphyc->vdda1v1),
+ "failed to get vdda1v1 supply\n");
goto clk_disable;
}

usbphyc->vdda1v8 = devm_regulator_get(dev, "vdda1v8");
if (IS_ERR(usbphyc->vdda1v8)) {
- ret = PTR_ERR(usbphyc->vdda1v8);
- if (ret != -EPROBE_DEFER)
- dev_err(dev, "failed to get vdda1v8 supply: %d\n", ret);
+ ret = dev_err_probe(dev, PTR_ERR(usbphyc->vdda1v8),
+ "failed to get vdda1v8 supply\n");
goto clk_disable;
}

--
2.7.4

2021-10-26 21:08:52

by Amelie Delaunay

Subject: Re: [PATCH] phy: stm32: adopt dev_err_probe for regulators

Hi Fabrice,

Thanks for your patch.

On 10/25/21 4:31 PM, Fabrice Gasnier wrote:
> Change stm32-usbphyc driver to use dev_err_probe(), to benefit of
> devices_deferred debugfs in case of probe deferral.
> > Signed-off-by: Fabrice Gasnier <[email protected]>

Reviewed-by: Amelie Delaunay <[email protected]>

> ---
> drivers/phy/st/phy-stm32-usbphyc.c | 10 ++++------
> 1 file changed, 4 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/phy/st/phy-stm32-usbphyc.c b/drivers/phy/st/phy-stm32-usbphyc.c
> index 7df6a63..115be0e 100644
> --- a/drivers/phy/st/phy-stm32-usbphyc.c
> +++ b/drivers/phy/st/phy-stm32-usbphyc.c
> @@ -672,17 +672,15 @@ static int stm32_usbphyc_probe(struct platform_device *pdev)
>
> usbphyc->vdda1v1 = devm_regulator_get(dev, "vdda1v1");
> if (IS_ERR(usbphyc->vdda1v1)) {
> - ret = PTR_ERR(usbphyc->vdda1v1);
> - if (ret != -EPROBE_DEFER)
> - dev_err(dev, "failed to get vdda1v1 supply: %d\n", ret);
> + ret = dev_err_probe(dev, PTR_ERR(usbphyc->vdda1v1),
> + "failed to get vdda1v1 supply\n");
> goto clk_disable;
> }
>
> usbphyc->vdda1v8 = devm_regulator_get(dev, "vdda1v8");
> if (IS_ERR(usbphyc->vdda1v8)) {
> - ret = PTR_ERR(usbphyc->vdda1v8);
> - if (ret != -EPROBE_DEFER)
> - dev_err(dev, "failed to get vdda1v8 supply: %d\n", ret);
> + ret = dev_err_probe(dev, PTR_ERR(usbphyc->vdda1v8),
> + "failed to get vdda1v8 supply\n");
> goto clk_disable;
> }
>
>

2021-11-23 05:19:48

by Vinod Koul

Subject: Re: [PATCH] phy: stm32: adopt dev_err_probe for regulators

On 25-10-21, 16:31, Fabrice Gasnier wrote:
> Change stm32-usbphyc driver to use dev_err_probe(), to benefit of
> devices_deferred debugfs in case of probe deferral.

Applied, thanks

--
~Vinod