2021-10-27 05:51:26

by Sandeep Maheswaram

Subject: [PATCH 0/3] Skip phy initialization for DWC3 USB Controllers

DWC3 manages PHY by own driver, so skip the management by HCD core.

Sandeep Maheswaram (3):
dt-bindings: usb: usb-xhci: Add bindings for usb-skip-phy-init
property
usb: host: xhci-plat: Add device property to set XHCI_SKIP_PHY_INIT
quirk
usb: dwc: host: Set the property usb-skip-phy-init

Documentation/devicetree/bindings/usb/usb-xhci.yaml | 4 ++++
drivers/usb/dwc3/host.c | 2 ++
drivers/usb/host/xhci-plat.c | 3 +++
3 files changed, 9 insertions(+)

--
2.7.4

2021-10-27 06:55:27

by Sandeep Maheswaram

Subject: [PATCH 3/3] usb: dwc: host: Set the property usb-skip-phy-init

dwc3 manages PHY by own DRD driver, so skip the management by
HCD core.
During runtime suspend phy was not getting suspend because
runtime_usage value is 2.

Signed-off-by: Sandeep Maheswaram <[email protected]>
---
drivers/usb/dwc3/host.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/usb/dwc3/host.c b/drivers/usb/dwc3/host.c
index f29a264..5144513 100644
--- a/drivers/usb/dwc3/host.c
+++ b/drivers/usb/dwc3/host.c
@@ -107,6 +107,8 @@ int dwc3_host_init(struct dwc3 *dwc)
if (DWC3_VER_IS_WITHIN(DWC3, ANY, 300A))
props[prop_idx++] = PROPERTY_ENTRY_BOOL("quirk-broken-port-ped");

+ props[prop_idx++] = PROPERTY_ENTRY_BOOL("usb-skip-phy-init");
+
if (prop_idx) {
ret = device_create_managed_software_node(&xhci->dev, props, NULL);
if (ret) {
--
2.7.4

2021-10-27 11:04:18

by Thinh Nguyen

Subject: Re: [PATCH 3/3] usb: dwc: host: Set the property usb-skip-phy-init

Sandeep Maheswaram wrote:
> dwc3 manages PHY by own DRD driver, so skip the management by
> HCD core.
> During runtime suspend phy was not getting suspend because
> runtime_usage value is 2.
>
> Signed-off-by: Sandeep Maheswaram <[email protected]>
> ---
> drivers/usb/dwc3/host.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/usb/dwc3/host.c b/drivers/usb/dwc3/host.c
> index f29a264..5144513 100644
> --- a/drivers/usb/dwc3/host.c
> +++ b/drivers/usb/dwc3/host.c
> @@ -107,6 +107,8 @@ int dwc3_host_init(struct dwc3 *dwc)
> if (DWC3_VER_IS_WITHIN(DWC3, ANY, 300A))
> props[prop_idx++] = PROPERTY_ENTRY_BOOL("quirk-broken-port-ped");
>
> + props[prop_idx++] = PROPERTY_ENTRY_BOOL("usb-skip-phy-init");

Increase props[] array size with this new change.

> +
> if (prop_idx) {
> ret = device_create_managed_software_node(&xhci->dev, props, NULL);
> if (ret) {
>

Can we update the $subject prefix from "dwc" to "dwc3"?

Thanks,
Thinh

2021-10-30 08:59:47

by Greg Kroah-Hartman

Subject: Re: [PATCH 3/3] usb: dwc: host: Set the property usb-skip-phy-init

On Tue, Oct 26, 2021 at 11:49:32PM +0530, Sandeep Maheswaram wrote:
> dwc3 manages PHY by own DRD driver, so skip the management by
> HCD core.
> During runtime suspend phy was not getting suspend because
> runtime_usage value is 2.
>
> Signed-off-by: Sandeep Maheswaram <[email protected]>
> ---
> drivers/usb/dwc3/host.c | 2 ++
> 1 file changed, 2 insertions(+)

Subject line should have "dwc3" not "dwc", right?

thanks,

greg k-h