2021-01-22 01:15:52

by Stephen Rothwell

[permalink] [raw]
Subject: linux-next: build warning after merge of the drm tree

Hi all,

After merging the drm tree, today's linux-next build (x86_64 allmodconfig)
produced this warning:

WARNING: unmet direct dependencies detected for DRM_I915_WERROR
Depends on [n]: HAS_IOMEM [=y] && DRM_I915 [=m] && EXPERT [=y] && !COMPILE_TEST [=y]
Selected by [m]:
- DRM_I915_DEBUG [=y] && HAS_IOMEM [=y] && EXPERT [=y] && DRM_I915 [=m]

WARNING: unmet direct dependencies detected for DRM_I915_WERROR
Depends on [n]: HAS_IOMEM [=y] && DRM_I915 [=m] && EXPERT [=y] && !COMPILE_TEST [=y]
Selected by [m]:
- DRM_I915_DEBUG [=y] && HAS_IOMEM [=y] && EXPERT [=y] && DRM_I915 [=m]

WARNING: unmet direct dependencies detected for DRM_I915_WERROR
Depends on [n]: HAS_IOMEM [=y] && DRM_I915 [=m] && EXPERT [=y] && !COMPILE_TEST [=y]
Selected by [m]:
- DRM_I915_DEBUG [=y] && HAS_IOMEM [=y] && EXPERT [=y] && DRM_I915 [=m]

Maybe introduced by commit

4f86975f539d ("drm/i915: Add DEBUG_GEM to the recommended CI config")

--
Cheers,
Stephen Rothwell


Attachments:
(No filename) (499.00 B)
OpenPGP digital signature

2021-01-22 07:21:46

by Daniel Vetter

[permalink] [raw]
Subject: Re: linux-next: build warning after merge of the drm tree

On Fri, Jan 22, 2021 at 1:59 AM Stephen Rothwell <[email protected]> wrote:
>
> Hi all,
>
> After merging the drm tree, today's linux-next build (x86_64 allmodconfig)
> produced this warning:
>
> WARNING: unmet direct dependencies detected for DRM_I915_WERROR
> Depends on [n]: HAS_IOMEM [=y] && DRM_I915 [=m] && EXPERT [=y] && !COMPILE_TEST [=y]
> Selected by [m]:
> - DRM_I915_DEBUG [=y] && HAS_IOMEM [=y] && EXPERT [=y] && DRM_I915 [=m]
>
> WARNING: unmet direct dependencies detected for DRM_I915_WERROR
> Depends on [n]: HAS_IOMEM [=y] && DRM_I915 [=m] && EXPERT [=y] && !COMPILE_TEST [=y]
> Selected by [m]:
> - DRM_I915_DEBUG [=y] && HAS_IOMEM [=y] && EXPERT [=y] && DRM_I915 [=m]
>
> WARNING: unmet direct dependencies detected for DRM_I915_WERROR
> Depends on [n]: HAS_IOMEM [=y] && DRM_I915 [=m] && EXPERT [=y] && !COMPILE_TEST [=y]
> Selected by [m]:
> - DRM_I915_DEBUG [=y] && HAS_IOMEM [=y] && EXPERT [=y] && DRM_I915 [=m]
>
> Maybe introduced by commit
>
> 4f86975f539d ("drm/i915: Add DEBUG_GEM to the recommended CI config")

Hm that has been in drm-intel-gt-next for a few days, is that tree not
in linux-next?
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

2021-01-22 07:32:45

by Stephen Rothwell

[permalink] [raw]
Subject: Re: linux-next: build warning after merge of the drm tree

Hi Daniel,

On Fri, 22 Jan 2021 08:17:58 +0100 Daniel Vetter <[email protected]> wrote:
>
> Hm that has been in drm-intel-gt-next for a few days, is that tree not
> in linux-next?

It is not.

These are the drm branches currently in linux-next:

drm-fixes git://git.freedesktop.org/git/drm/drm.git drm-fixes
amdgpu-fixes git://people.freedesktop.org/~agd5f/linux drm-fixes
drm-intel-fixes git://anongit.freedesktop.org/drm-intel for-linux-next-fixes
drm-misc-fixes git://anongit.freedesktop.org/drm/drm-misc for-linux-next-fixes
drm git://git.freedesktop.org/git/drm/drm.git drm-next
amdgpu https://gitlab.freedesktop.org/agd5f/linux drm-next
drm-intel git://anongit.freedesktop.org/drm-intel for-linux-next
drm-tegra git://anongit.freedesktop.org/tegra/linux.git drm/tegra/for-next
drm-misc git://anongit.freedesktop.org/drm/drm-misc for-linux-next
drm-msm https://gitlab.freedesktop.org/drm/msm.git msm-next
imx-drm https://git.pengutronix.de/git/pza/linux imx-drm/next
etnaviv https://git.pengutronix.de/git/lst/linux etnaviv/next

--
Cheers,
Stephen Rothwell


Attachments:
(No filename) (499.00 B)
OpenPGP digital signature

2021-01-22 08:45:03

by Daniel Vetter

[permalink] [raw]
Subject: Re: linux-next: build warning after merge of the drm tree

On Fri, Jan 22, 2021 at 8:29 AM Stephen Rothwell <[email protected]> wrote:
>
> Hi Daniel,
>
> On Fri, 22 Jan 2021 08:17:58 +0100 Daniel Vetter <[email protected]> wrote:
> >
> > Hm that has been in drm-intel-gt-next for a few days, is that tree not
> > in linux-next?
>
> It is not.

Adding -intel maintainers to get that sorted.
-Daniel

> These are the drm branches currently in linux-next:

Oh for ordering maybe put drm-misc ahead of the other subtrees, -misc
is where nowadays a lot of refactorings and core changes land.
Probably doesn't matter in practice.
-Daniel

> drm-fixes git://git.freedesktop.org/git/drm/drm.git drm-fixes
> amdgpu-fixes git://people.freedesktop.org/~agd5f/linux drm-fixes
> drm-intel-fixes git://anongit.freedesktop.org/drm-intel for-linux-next-fixes
> drm-misc-fixes git://anongit.freedesktop.org/drm/drm-misc for-linux-next-fixes
> drm git://git.freedesktop.org/git/drm/drm.git drm-next
> amdgpu https://gitlab.freedesktop.org/agd5f/linux drm-next
> drm-intel git://anongit.freedesktop.org/drm-intel for-linux-next
> drm-tegra git://anongit.freedesktop.org/tegra/linux.git drm/tegra/for-next
> drm-misc git://anongit.freedesktop.org/drm/drm-misc for-linux-next
> drm-msm https://gitlab.freedesktop.org/drm/msm.git msm-next
> imx-drm https://git.pengutronix.de/git/pza/linux imx-drm/next
> etnaviv https://git.pengutronix.de/git/lst/linux etnaviv/next
>
> --
> Cheers,
> Stephen Rothwell



--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

2021-02-01 01:57:16

by Stephen Rothwell

[permalink] [raw]
Subject: Re: linux-next: build warning after merge of the drm tree

Hi all,

On Fri, 22 Jan 2021 11:59:18 +1100 Stephen Rothwell <[email protected]> wrote:
>
> After merging the drm tree, today's linux-next build (x86_64 allmodconfig)
> produced this warning:
>
> WARNING: unmet direct dependencies detected for DRM_I915_WERROR
> Depends on [n]: HAS_IOMEM [=y] && DRM_I915 [=m] && EXPERT [=y] && !COMPILE_TEST [=y]
> Selected by [m]:
> - DRM_I915_DEBUG [=y] && HAS_IOMEM [=y] && EXPERT [=y] && DRM_I915 [=m]
>
> WARNING: unmet direct dependencies detected for DRM_I915_WERROR
> Depends on [n]: HAS_IOMEM [=y] && DRM_I915 [=m] && EXPERT [=y] && !COMPILE_TEST [=y]
> Selected by [m]:
> - DRM_I915_DEBUG [=y] && HAS_IOMEM [=y] && EXPERT [=y] && DRM_I915 [=m]
>
> WARNING: unmet direct dependencies detected for DRM_I915_WERROR
> Depends on [n]: HAS_IOMEM [=y] && DRM_I915 [=m] && EXPERT [=y] && !COMPILE_TEST [=y]
> Selected by [m]:
> - DRM_I915_DEBUG [=y] && HAS_IOMEM [=y] && EXPERT [=y] && DRM_I915 [=m]
>
> Maybe introduced by commit
>
> 4f86975f539d ("drm/i915: Add DEBUG_GEM to the recommended CI config")

I am still getting this warning.

--
Cheers,
Stephen Rothwell


Attachments:
(No filename) (499.00 B)
OpenPGP digital signature

2021-10-27 21:24:45

by Joonas Lahtinen

[permalink] [raw]
Subject: Re: linux-next: build warning after merge of the drm tree

(+ Tvrtko who was recently added as a drm/i915 co-maintainer)

Quoting Daniel Vetter (2021-01-22 10:40:48)
> On Fri, Jan 22, 2021 at 8:29 AM Stephen Rothwell <[email protected]> wrote:
> >
> > Hi Daniel,
> >
> > On Fri, 22 Jan 2021 08:17:58 +0100 Daniel Vetter <[email protected]> wrote:
> > >
> > > Hm that has been in drm-intel-gt-next for a few days, is that tree not
> > > in linux-next?
> >
> > It is not.

Hi Stephen,

We should be now good to go and add drm-intel-gt-next to linux-next.

The branch would be as follows:

drm-intel-gt-next git://anongit.freedesktop.org/drm-intel for-linux-next-gt

Notice the "-gt" and the end of the for-linux-next branch name. This should eliminate
the gap we have been having. The change to add it to the DIM tool is here:

https://gitlab.freedesktop.org/drm/maintainer-tools/-/commit/7b5c2c29cdbc054e8c8fce38f095c56290fc4833

So once all developers have updated their tooling (for which they will
get an automatic nag message) we should be all up-to-date for future
merge windows.

Regards, Joonas

> Adding -intel maintainers to get that sorted.
> -Daniel
>
> > These are the drm branches currently in linux-next:
>
> Oh for ordering maybe put drm-misc ahead of the other subtrees, -misc
> is where nowadays a lot of refactorings and core changes land.
> Probably doesn't matter in practice.
> -Daniel
>
> > drm-fixes git://git.freedesktop.org/git/drm/drm.git drm-fixes
> > amdgpu-fixes git://people.freedesktop.org/~agd5f/linux drm-fixes
> > drm-intel-fixes git://anongit.freedesktop.org/drm-intel for-linux-next-fixes
> > drm-misc-fixes git://anongit.freedesktop.org/drm/drm-misc for-linux-next-fixes
> > drm git://git.freedesktop.org/git/drm/drm.git drm-next
> > amdgpu https://gitlab.freedesktop.org/agd5f/linux drm-next
> > drm-intel git://anongit.freedesktop.org/drm-intel for-linux-next
> > drm-tegra git://anongit.freedesktop.org/tegra/linux.git drm/tegra/for-next
> > drm-misc git://anongit.freedesktop.org/drm/drm-misc for-linux-next
> > drm-msm https://gitlab.freedesktop.org/drm/msm.git msm-next
> > imx-drm https://git.pengutronix.de/git/pza/linux imx-drm/next
> > etnaviv https://git.pengutronix.de/git/lst/linux etnaviv/next
> >
> > --
> > Cheers,
> > Stephen Rothwell
>
>
>
> --
> Daniel Vetter
> Software Engineer, Intel Corporation
> http://blog.ffwll.ch

2021-10-27 21:37:39

by Stephen Rothwell

[permalink] [raw]
Subject: Re: linux-next: build warning after merge of the drm tree

Hi Joonas,

On Wed, 27 Oct 2021 15:12:44 +0300 Joonas Lahtinen <[email protected]> wrote:
>
> We should be now good to go and add drm-intel-gt-next to linux-next.
>
> The branch would be as follows:
>
> drm-intel-gt-next git://anongit.freedesktop.org/drm-intel for-linux-next-gt
>
> Notice the "-gt" and the end of the for-linux-next branch name. This should eliminate
> the gap we have been having.

I have added it to linux-next from today. I called it just
"drm-intel-gt" for consistency with the other drm trees in linux-next.

Currently I just have you listed as a contact, is there anyone else (or
a list) that I should add?

Thanks for adding your subsystem tree as a participant of linux-next. As
you may know, this is not a judgement of your code. The purpose of
linux-next is for integration testing and to lower the impact of
conflicts between subsystems in the next merge window.

You will need to ensure that the patches/commits in your tree/series have
been:
* submitted under GPL v2 (or later) and include the Contributor's
Signed-off-by,
* posted to the relevant mailing list,
* reviewed by you (or another maintainer of your subsystem tree),
* successfully unit tested, and
* destined for the current or next Linux merge window.

Basically, this should be just what you would send to Linus (or ask him
to fetch). It is allowed to be rebased if you deem it necessary.

--
Cheers,
Stephen Rothwell
[email protected]

--
Cheers,
Stephen Rothwell


Attachments:
(No filename) (499.00 B)
OpenPGP digital signature

2021-10-28 09:44:32

by Joonas Lahtinen

[permalink] [raw]
Subject: Re: linux-next: build warning after merge of the drm tree

Quoting Stephen Rothwell (2021-10-27 23:51:55)
> Hi Joonas,
>
> On Wed, 27 Oct 2021 15:12:44 +0300 Joonas Lahtinen <[email protected]> wrote:
> >
> > We should be now good to go and add drm-intel-gt-next to linux-next.
> >
> > The branch would be as follows:
> >
> > drm-intel-gt-next git://anongit.freedesktop.org/drm-intel for-linux-next-gt
> >
> > Notice the "-gt" and the end of the for-linux-next branch name. This should eliminate
> > the gap we have been having.
>
> I have added it to linux-next from today.

Thanks!

> I called it just
> "drm-intel-gt" for consistency with the other drm trees in linux-next.

We use the drm-intel-gt-next as the branch name in repo and DIM tolling, so if
we are after consistenty consistency, using the full name probably makes
sense. drm-intel-gt-next for name keeps open the option for separating
the drm-intel-gt-fixes too, if we decide to do so in the future.

> Currently I just have you listed as a contact, is there anyone else (or
> a list) that I should add?

Please do add Tvrtko (Cc'd). I guess it might make sense adding Jani and
Rodrigo too, as backups. Similarly Tvrtko could be added to the other
drm-intel-* trees. Doesn't hurt to have more eyes especially if some
folks are on a vacation.

Regards, Joonas

> Thanks for adding your subsystem tree as a participant of linux-next. As
> you may know, this is not a judgement of your code. The purpose of
> linux-next is for integration testing and to lower the impact of
> conflicts between subsystems in the next merge window.
>
> You will need to ensure that the patches/commits in your tree/series have
> been:
> * submitted under GPL v2 (or later) and include the Contributor's
> Signed-off-by,
> * posted to the relevant mailing list,
> * reviewed by you (or another maintainer of your subsystem tree),
> * successfully unit tested, and
> * destined for the current or next Linux merge window.
>
> Basically, this should be just what you would send to Linus (or ask him
> to fetch). It is allowed to be rebased if you deem it necessary.
>
> --
> Cheers,
> Stephen Rothwell
> [email protected]
>
> --
> Cheers,
> Stephen Rothwell