2021-11-18 12:51:30

by Srinivasa Rao Mandadapu

[permalink] [raw]
Subject: [PATCH v5 00/10] Add support for audio on SC7280 based targets

This patch set is to add support for Audio over wcd codec,
digital mics, through digital codecs and without ADSP.
This patch set depends on:
-- https://patchwork.kernel.org/project/alsa-devel/list/?series=570161
-- https://patchwork.kernel.org/project/alsa-devel/list/?series=572615
-- https://patchwork.kernel.org/project/alsa-devel/list/?series=559677

Changes Since V4:
-- Remove unused variable in lpass-sc7280 platform driver.
Changes Since V3:
-- Remove redundant power domain controls. As power domains can be configured from dtsi.
Changes Since V2:
-- Split lpass sc7280 cpu driver patch and create regmap config patch.
-- Create patches based on latest kernel tip.
-- Add helper function to get dma control and lpaif handle.
-- Remove unused variables.
Changes Since V1:
-- Typo errors fix
-- CPU driver readable/writable apis optimization.
-- Add Missing config patch
-- Add Common api for repeated dmactl initialization.

Srinivasa Rao Mandadapu (10):
ASoC: qcom: Move lpass_pcm_data structure to lpass header
ASoC: qcom: lpass: Add dma fields for codec dma lpass interface
ASoC: qcom: Add register definition for codec rddma and wrdma
ASoC: qcom: Add lpass CPU driver for codec dma control
ASoC: qcom: Add helper function to get dma control and lpaif handle
ASoC: qcom: Add support for codec dma driver
ASoC: qcom: Add regmap config support for codec dma driver
ASoC: dt-bindings: Add SC7280 sound card bindings
ASoC: qcom: lpass-sc7280: Add platform driver for lpass audio
ASoC: qcom: SC7280: Update config for building codec dma drivers

.../devicetree/bindings/sound/qcom,lpass-cpu.yaml | 69 ++-
sound/soc/qcom/Kconfig | 13 +
sound/soc/qcom/Makefile | 4 +
sound/soc/qcom/common.c | 39 ++
sound/soc/qcom/common.h | 1 +
sound/soc/qcom/lpass-cdc-dma.c | 195 ++++++++
sound/soc/qcom/lpass-cpu.c | 245 +++++++++-
sound/soc/qcom/lpass-lpaif-reg.h | 103 ++++-
sound/soc/qcom/lpass-platform.c | 513 ++++++++++++++++++---
sound/soc/qcom/lpass-sc7280.c | 416 +++++++++++++++++
sound/soc/qcom/lpass.h | 150 ++++++
11 files changed, 1669 insertions(+), 79 deletions(-)
create mode 100644 sound/soc/qcom/lpass-cdc-dma.c
create mode 100644 sound/soc/qcom/lpass-sc7280.c

--
Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc.,
is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.



2021-11-23 12:28:20

by Srinivas Kandagatla

[permalink] [raw]
Subject: Re: [PATCH v5 00/10] Add support for audio on SC7280 based targets



On 18/11/2021 12:48, Srinivasa Rao Mandadapu wrote:
> This patch set is to add support for Audio over wcd codec,
> digital mics, through digital codecs and without ADSP.
> This patch set depends on:

> -- https://patchwork.kernel.org/project/alsa-devel/list/?series=570161

> -- https://patchwork.kernel.org/project/alsa-devel/list/?series=572615

Except this one, rest of the patches are already in sound-next.
and the only dependency I see here is the final patch which adds
Kconfigs to the soundcard SND_SOC_SC7280.
Why not just move those two lines in the patchset that adds the soundcard?



--srini


> -- https://patchwork.kernel.org/project/alsa-devel/list/?series=559677

>
> Changes Since V4:
> -- Remove unused variable in lpass-sc7280 platform driver.
> Changes Since V3:
> -- Remove redundant power domain controls. As power domains can be configured from dtsi.
> Changes Since V2:
> -- Split lpass sc7280 cpu driver patch and create regmap config patch.
> -- Create patches based on latest kernel tip.
> -- Add helper function to get dma control and lpaif handle.
> -- Remove unused variables.
> Changes Since V1:
> -- Typo errors fix
> -- CPU driver readable/writable apis optimization.
> -- Add Missing config patch
> -- Add Common api for repeated dmactl initialization.
>
> Srinivasa Rao Mandadapu (10):
> ASoC: qcom: Move lpass_pcm_data structure to lpass header
> ASoC: qcom: lpass: Add dma fields for codec dma lpass interface
> ASoC: qcom: Add register definition for codec rddma and wrdma
> ASoC: qcom: Add lpass CPU driver for codec dma control
> ASoC: qcom: Add helper function to get dma control and lpaif handle
> ASoC: qcom: Add support for codec dma driver
> ASoC: qcom: Add regmap config support for codec dma driver
> ASoC: dt-bindings: Add SC7280 sound card bindings
> ASoC: qcom: lpass-sc7280: Add platform driver for lpass audio
> ASoC: qcom: SC7280: Update config for building codec dma drivers
>
> .../devicetree/bindings/sound/qcom,lpass-cpu.yaml | 69 ++-
> sound/soc/qcom/Kconfig | 13 +
> sound/soc/qcom/Makefile | 4 +
> sound/soc/qcom/common.c | 39 ++
> sound/soc/qcom/common.h | 1 +
> sound/soc/qcom/lpass-cdc-dma.c | 195 ++++++++
> sound/soc/qcom/lpass-cpu.c | 245 +++++++++-
> sound/soc/qcom/lpass-lpaif-reg.h | 103 ++++-
> sound/soc/qcom/lpass-platform.c | 513 ++++++++++++++++++---
> sound/soc/qcom/lpass-sc7280.c | 416 +++++++++++++++++
> sound/soc/qcom/lpass.h | 150 ++++++
> 11 files changed, 1669 insertions(+), 79 deletions(-)
> create mode 100644 sound/soc/qcom/lpass-cdc-dma.c
> create mode 100644 sound/soc/qcom/lpass-sc7280.c
>

2021-11-26 04:41:48

by Srinivasa Rao Mandadapu

[permalink] [raw]
Subject: Re: [PATCH v5 00/10] Add support for audio on SC7280 based targets


On 11/23/2021 5:58 PM, Srinivas Kandagatla wrote:
Thanks for your time Srini!!!
>
> On 18/11/2021 12:48, Srinivasa Rao Mandadapu wrote:
>> This patch set is to add support for Audio over wcd codec,
>> digital mics, through digital codecs and without ADSP.
>> This patch set depends on:
>
>>     --
>> https://patchwork.kernel.org/project/alsa-devel/list/?series=570161
>
>>     --
>> https://patchwork.kernel.org/project/alsa-devel/list/?series=572615
>
> Except this one, rest of the patches are already in sound-next.
> and the only dependency I see here is the final patch which adds
> Kconfigs to the soundcard SND_SOC_SC7280.
> Why not just move those two lines in the patchset that adds the
> soundcard?
>
>
>
> --srini
>
Okay. will move this dependency to corresponding patch.
>
>>     --
>> https://patchwork.kernel.org/project/alsa-devel/list/?series=559677
>
>>
>> Changes Since V4:
>>      -- Remove unused variable in lpass-sc7280 platform driver.
>> Changes Since V3:
>>      -- Remove redundant power domain controls. As power domains can
>> be configured from dtsi.
>> Changes Since V2:
>>      -- Split lpass sc7280 cpu driver patch and create regmap config
>> patch.
>>      -- Create patches based on latest kernel tip.
>>      -- Add helper function to get dma control and lpaif handle.
>>      -- Remove unused variables.
>> Changes Since V1:
>>      -- Typo errors fix
>>      -- CPU driver readable/writable apis optimization.
>>      -- Add Missing config patch
>>      -- Add Common api for repeated dmactl initialization.
>>
>> Srinivasa Rao Mandadapu (10):
>>    ASoC: qcom: Move lpass_pcm_data structure to lpass header
>>    ASoC: qcom: lpass: Add dma fields for codec dma lpass interface
>>    ASoC: qcom: Add register definition for codec rddma and wrdma
>>    ASoC: qcom: Add lpass CPU driver for codec dma control
>>    ASoC: qcom: Add helper function to get dma control and lpaif handle
>>    ASoC: qcom: Add support for codec dma driver
>>    ASoC: qcom: Add regmap config support for codec dma driver
>>    ASoC: dt-bindings: Add SC7280 sound card bindings
>>    ASoC: qcom: lpass-sc7280: Add platform driver for lpass audio
>>    ASoC: qcom: SC7280: Update config for building codec dma drivers
>>
>>   .../devicetree/bindings/sound/qcom,lpass-cpu.yaml  |  69 ++-
>>   sound/soc/qcom/Kconfig                             |  13 +
>>   sound/soc/qcom/Makefile                            |   4 +
>>   sound/soc/qcom/common.c                            |  39 ++
>>   sound/soc/qcom/common.h                            |   1 +
>>   sound/soc/qcom/lpass-cdc-dma.c                     | 195 ++++++++
>>   sound/soc/qcom/lpass-cpu.c                         | 245 +++++++++-
>>   sound/soc/qcom/lpass-lpaif-reg.h                   | 103 ++++-
>>   sound/soc/qcom/lpass-platform.c                    | 513
>> ++++++++++++++++++---
>>   sound/soc/qcom/lpass-sc7280.c                      | 416
>> +++++++++++++++++
>>   sound/soc/qcom/lpass.h                             | 150 ++++++
>>   11 files changed, 1669 insertions(+), 79 deletions(-)
>>   create mode 100644 sound/soc/qcom/lpass-cdc-dma.c
>>   create mode 100644 sound/soc/qcom/lpass-sc7280.c
>>
--
Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc.,
is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.