2021-12-01 14:54:38

by Horatiu Vultur

Subject: [PATCH net-next] net: lan966x: Fix duplicate check in frame extraction

The blamed commit generates the following smatch static checker warning:

drivers/net/ethernet/microchip/lan966x/lan966x_main.c:515 lan966x_xtr_irq_handler()
warn: duplicate check 'sz < 0' (previous on line 502)

This patch fixes this issue removing the duplicate check 'sz < 0'

Fixes: d28d6d2e37d10d ("net: lan966x: add port module support")
Signed-off-by: Horatiu Vultur <[email protected]>
---
drivers/net/ethernet/microchip/lan966x/lan966x_main.c | 5 -----
1 file changed, 5 deletions(-)

diff --git a/drivers/net/ethernet/microchip/lan966x/lan966x_main.c b/drivers/net/ethernet/microchip/lan966x/lan966x_main.c
index e9e4dca6542d..be5e2b3a7f43 100644
--- a/drivers/net/ethernet/microchip/lan966x/lan966x_main.c
+++ b/drivers/net/ethernet/microchip/lan966x/lan966x_main.c
@@ -512,11 +512,6 @@ static irqreturn_t lan966x_xtr_irq_handler(int irq, void *args)
*buf = val;
}

- if (sz < 0) {
- err = sz;
- break;
- }
-
skb->protocol = eth_type_trans(skb, dev);

netif_rx_ni(skb);
--
2.33.0

2021-12-02 12:20:32

by patchwork-bot+netdevbpf

Subject: Re: [PATCH net-next] net: lan966x: Fix duplicate check in frame extraction

Hello:

This patch was applied to netdev/net-next.git (master)
by David S. Miller <[email protected]>:

On Wed, 1 Dec 2021 15:53:51 +0100 you wrote:
> The blamed commit generates the following smatch static checker warning:
>
> drivers/net/ethernet/microchip/lan966x/lan966x_main.c:515 lan966x_xtr_irq_handler()
> warn: duplicate check 'sz < 0' (previous on line 502)
>
> This patch fixes this issue removing the duplicate check 'sz < 0'
>
> [...]

Here is the summary with links:
- [net-next] net: lan966x: Fix duplicate check in frame extraction
https://git.kernel.org/netdev/net-next/c/a290cf692779

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html