2021-12-05 19:04:27

by José Expósito

Subject: [PATCH] media: venus: helpers: Fix memory leak in venus_helper_alloc_dpb_bufs

Addresses-Coverity-ID: 1494120 ("Resource leaks")
Signed-off-by: José Expósito <[email protected]>
---
drivers/media/platform/qcom/venus/helpers.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/media/platform/qcom/venus/helpers.c b/drivers/media/platform/qcom/venus/helpers.c
index 84c3a511ec31..344a42853898 100644
--- a/drivers/media/platform/qcom/venus/helpers.c
+++ b/drivers/media/platform/qcom/venus/helpers.c
@@ -197,6 +197,7 @@ int venus_helper_alloc_dpb_bufs(struct venus_inst *inst)

id = ida_alloc_min(&inst->dpb_ids, VB2_MAX_FRAME, GFP_KERNEL);
if (id < 0) {
+ kfree(buf);
ret = id;
goto fail;
}
--
2.25.1

2021-12-06 09:49:21

by Kieran Bingham

Subject: Re: [PATCH] media: venus: helpers: Fix memory leak in venus_helper_alloc_dpb_bufs

Hi José

Quoting José Expósito (2021-12-05 19:04:15)
> Addresses-Coverity-ID: 1494120 ("Resource leaks")

This was also recently posted by Ameer in https://lore.kernel.org/all/[email protected]/

Regards
--
Kieran

> Signed-off-by: José Expósito <[email protected]>
> ---
> drivers/media/platform/qcom/venus/helpers.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/media/platform/qcom/venus/helpers.c b/drivers/media/platform/qcom/venus/helpers.c
> index 84c3a511ec31..344a42853898 100644
> --- a/drivers/media/platform/qcom/venus/helpers.c
> +++ b/drivers/media/platform/qcom/venus/helpers.c
> @@ -197,6 +197,7 @@ int venus_helper_alloc_dpb_bufs(struct venus_inst *inst)
>
> id = ida_alloc_min(&inst->dpb_ids, VB2_MAX_FRAME, GFP_KERNEL);
> if (id < 0) {
> + kfree(buf);
> ret = id;
> goto fail;
> }
> --
> 2.25.1
>