2021-11-30 08:09:41

by Manivannan Sadhasivam

Subject: [PATCH v3] PCI: qcom: Use __be16 type to store return value from cpu_to_be16()

cpu_to_be16() returns __be16 value but the driver uses u16 and that's
incorrect. Fix it by using __be16 as the data type of bdf_be variable.

The issue was spotted by the below sparse warning:

sparse warnings: (new ones prefixed by >>)
>> drivers/pci/controller/dwc/pcie-qcom.c:1305:30: sparse: sparse: incorrect type in initializer (different base types) @@ expected unsigned short [usertype] bdf_be @@ got restricted __be16 [usertype] @@
drivers/pci/controller/dwc/pcie-qcom.c:1305:30: sparse: expected unsigned short [usertype] bdf_be
drivers/pci/controller/dwc/pcie-qcom.c:1305:30: sparse: got restricted __be16 [usertype]

Reported-by: kernel test robot <[email protected]>
Reviewed-by: Krzysztof Wilczyński <[email protected]>
Signed-off-by: Manivannan Sadhasivam <[email protected]>
---

Changes in v3:

* Added Krzysztof's reviewed-by tag and modified the commit message as per
his comments

Changes in v2:

* Modified the commit message and subject to describe the actual issue
as per comments from Bjorn.

drivers/pci/controller/dwc/pcie-qcom.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pci/controller/dwc/pcie-qcom.c b/drivers/pci/controller/dwc/pcie-qcom.c
index 1c3d1116bb60..ddecd7f341c5 100644
--- a/drivers/pci/controller/dwc/pcie-qcom.c
+++ b/drivers/pci/controller/dwc/pcie-qcom.c
@@ -1343,7 +1343,7 @@ static int qcom_pcie_config_sid_sm8250(struct qcom_pcie *pcie)

/* Look for an available entry to hold the mapping */
for (i = 0; i < nr_map; i++) {
- u16 bdf_be = cpu_to_be16(map[i].bdf);
+ __be16 bdf_be = cpu_to_be16(map[i].bdf);
u32 val;
u8 hash;

--
2.25.1

2021-12-06 10:31:18

by Lorenzo Pieralisi

Subject: Re: [PATCH v3] PCI: qcom: Use __be16 type to store return value from cpu_to_be16()

On Tue, 30 Nov 2021 13:39:24 +0530, Manivannan Sadhasivam wrote:
> cpu_to_be16() returns __be16 value but the driver uses u16 and that's
> incorrect. Fix it by using __be16 as the data type of bdf_be variable.
>
> The issue was spotted by the below sparse warning:
>
> sparse warnings: (new ones prefixed by >>)
> >> drivers/pci/controller/dwc/pcie-qcom.c:1305:30: sparse: sparse: incorrect type in initializer (different base types) @@ expected unsigned short [usertype] bdf_be @@ got restricted __be16 [usertype] @@
> drivers/pci/controller/dwc/pcie-qcom.c:1305:30: sparse: expected unsigned short [usertype] bdf_be
> drivers/pci/controller/dwc/pcie-qcom.c:1305:30: sparse: got restricted __be16 [usertype]
>
> [...]

Applied to pci/qcom, thanks!

[1/1] PCI: qcom: Use __be16 type to store return value from cpu_to_be16()
https://git.kernel.org/lpieralisi/pci/c/3f13d611aa

Thanks,
Lorenzo