2021-12-09 12:22:05

by 王擎

Subject: [PATCH] irqchip: irq-bcm7120-l2: add missing put_device() call in bcm7120_l2_intc_probe()

From: Wang Qing <[email protected]>

of_find_device_by_node() takes a reference to the embedded struct device
which needs to be dropped when error return.

Signed-off-by: Wang Qing <[email protected]>
---
drivers/irqchip/irq-bcm7120-l2.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/irqchip/irq-bcm7120-l2.c b/drivers/irqchip/irq-bcm7120-l2.c
index d80e67a..24573ca
--- a/drivers/irqchip/irq-bcm7120-l2.c
+++ b/drivers/irqchip/irq-bcm7120-l2.c
@@ -336,6 +336,7 @@ static int __init bcm7120_l2_intc_probe(struct device_node *dn,
if (data->map_base[idx])
iounmap(data->map_base[idx]);
}
+ put_device(&pdev->dev);
out_free_data:
kfree(data);
return ret;
--
2.7.4

2021-12-09 16:58:13

by Florian Fainelli

Subject: Re: [PATCH] irqchip: irq-bcm7120-l2: add missing put_device() call in bcm7120_l2_intc_probe()

On 12/9/21 4:21 AM, Qing Wang wrote:
> From: Wang Qing <[email protected]>
>
> of_find_device_by_node() takes a reference to the embedded struct device
> which needs to be dropped when error return.
>
> Signed-off-by: Wang Qing <[email protected]>

This has been submitted already with:

https://lore.kernel.org/lkml/[email protected]/
--
Florian