2021-12-13 10:16:17

by Tiezhu Yang

Subject: [PATCH v3 0/2] MIPS: Remove some code

Thanks Nathan, Masahiro and Ryutaroh.

Tiezhu Yang (2):
MIPS: SGI-IP22: Remove unnecessary check of GCC option
MIPS: Makefile: Remove "ifdef need-compiler" for Kbuild.platforms

arch/mips/Makefile | 2 --
arch/mips/sgi-ip22/Platform | 5 -----
2 files changed, 7 deletions(-)

--
2.1.0

2021-12-13 10:16:20

by Tiezhu Yang

Subject: [PATCH v3 2/2] MIPS: Makefile: Remove "ifdef need-compiler" for Kbuild.platforms

After commit 13ceb48bc19c ("MIPS: Loongson2ef: Remove unnecessary
{as,cc}-option calls"), no need to use "ifdef need-compiler" for
Kbuild.platforms, because the cause of the build issue mentioned
in commit 0706f74f719e ("MIPS: fix *-pkg builds for loongson2ef
platform") has been disappeared, so just remove it.

Signed-off-by: Tiezhu Yang <[email protected]>
---
arch/mips/Makefile | 2 --
1 file changed, 2 deletions(-)

diff --git a/arch/mips/Makefile b/arch/mips/Makefile
index ace7f03..e036fc0 100644
--- a/arch/mips/Makefile
+++ b/arch/mips/Makefile
@@ -253,9 +253,7 @@ endif
#
# Board-dependent options and extra files
#
-ifdef need-compiler
include $(srctree)/arch/mips/Kbuild.platforms
-endif

ifdef CONFIG_PHYSICAL_START
load-y = $(CONFIG_PHYSICAL_START)
--
2.1.0

2021-12-13 17:13:25

by Nathan Chancellor

Subject: Re: [PATCH v3 2/2] MIPS: Makefile: Remove "ifdef need-compiler" for Kbuild.platforms

On Mon, Dec 13, 2021 at 05:57:57PM +0800, Tiezhu Yang wrote:
> After commit 13ceb48bc19c ("MIPS: Loongson2ef: Remove unnecessary
> {as,cc}-option calls"), no need to use "ifdef need-compiler" for
> Kbuild.platforms, because the cause of the build issue mentioned
> in commit 0706f74f719e ("MIPS: fix *-pkg builds for loongson2ef
> platform") has been disappeared, so just remove it.
>
> Signed-off-by: Tiezhu Yang <[email protected]>

Reviewed-by: Nathan Chancellor <[email protected]>

> ---
> arch/mips/Makefile | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/mips/Makefile b/arch/mips/Makefile
> index ace7f03..e036fc0 100644
> --- a/arch/mips/Makefile
> +++ b/arch/mips/Makefile
> @@ -253,9 +253,7 @@ endif
> #
> # Board-dependent options and extra files
> #
> -ifdef need-compiler
> include $(srctree)/arch/mips/Kbuild.platforms
> -endif
>
> ifdef CONFIG_PHYSICAL_START
> load-y = $(CONFIG_PHYSICAL_START)
> --
> 2.1.0
>

2021-12-14 01:32:21

by Masahiro Yamada

Subject: Re: [PATCH v3 2/2] MIPS: Makefile: Remove "ifdef need-compiler" for Kbuild.platforms

On Mon, Dec 13, 2021 at 6:58 PM Tiezhu Yang <[email protected]> wrote:
>
> After commit 13ceb48bc19c ("MIPS: Loongson2ef: Remove unnecessary
> {as,cc}-option calls"), no need to use "ifdef need-compiler" for
> Kbuild.platforms, because the cause of the build issue mentioned
> in commit 0706f74f719e ("MIPS: fix *-pkg builds for loongson2ef
> platform") has been disappeared, so just remove it.
>
> Signed-off-by: Tiezhu Yang <[email protected]>
> ---


Reviewed-by: Masahiro Yamada <[email protected]>


> arch/mips/Makefile | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/mips/Makefile b/arch/mips/Makefile
> index ace7f03..e036fc0 100644
> --- a/arch/mips/Makefile
> +++ b/arch/mips/Makefile
> @@ -253,9 +253,7 @@ endif
> #
> # Board-dependent options and extra files
> #
> -ifdef need-compiler
> include $(srctree)/arch/mips/Kbuild.platforms
> -endif
>
> ifdef CONFIG_PHYSICAL_START
> load-y = $(CONFIG_PHYSICAL_START)
> --
> 2.1.0
>


--
Best Regards
Masahiro Yamada