2021-12-14 12:18:50

by 王擎

Subject: [PATCH] platform: x86: use resource_size() with res

From: Wang Qing <[email protected]>

This should be (res->end - res->start + 1) here actually,
use resource_size() derectly.

Signed-off-by: Wang Qing <[email protected]>
---
drivers/platform/x86/apple-gmux.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/platform/x86/apple-gmux.c b/drivers/platform/x86/apple-gmux.c
index 9aae45a..57553f9
--- a/drivers/platform/x86/apple-gmux.c
+++ b/drivers/platform/x86/apple-gmux.c
@@ -625,7 +625,7 @@ static int gmux_probe(struct pnp_dev *pnp, const struct pnp_device_id *id)
}

gmux_data->iostart = res->start;
- gmux_data->iolen = res->end - res->start;
+ gmux_data->iolen = resource_size(res);

if (gmux_data->iolen < GMUX_MIN_IO_LEN) {
pr_err("gmux I/O region too small (%lu < %u)\n",
--
2.7.4

2021-12-21 17:55:22

by Hans de Goede

Subject: Re: [PATCH] platform: x86: use resource_size() with res

Hi,

On 12/14/21 13:18, Qing Wang wrote:
> From: Wang Qing <[email protected]>
>
> This should be (res->end - res->start + 1) here actually,
> use resource_size() derectly.
>
> Signed-off-by: Wang Qing <[email protected]>

Thank you for your patch, I've applied this patch to my review-hans
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans

Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.

Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.

Regards,

Hans


> ---
> drivers/platform/x86/apple-gmux.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/apple-gmux.c b/drivers/platform/x86/apple-gmux.c
> index 9aae45a..57553f9
> --- a/drivers/platform/x86/apple-gmux.c
> +++ b/drivers/platform/x86/apple-gmux.c
> @@ -625,7 +625,7 @@ static int gmux_probe(struct pnp_dev *pnp, const struct pnp_device_id *id)
> }
>
> gmux_data->iostart = res->start;
> - gmux_data->iolen = res->end - res->start;
> + gmux_data->iolen = resource_size(res);
>
> if (gmux_data->iolen < GMUX_MIN_IO_LEN) {
> pr_err("gmux I/O region too small (%lu < %u)\n",
>